Prohibit creation of different plain disks with the shared object storage paths#89038
Merged
Michicosun merged 8 commits intomasterfrom Oct 28, 2025
Merged
Prohibit creation of different plain disks with the shared object storage paths#89038Michicosun merged 8 commits intomasterfrom
Michicosun merged 8 commits intomasterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-backward-incompatible
Member
Hm, it should be only |
azat
reviewed
Oct 27, 2025
azat
reviewed
Oct 27, 2025
KochetovNicolai
approved these changes
Oct 28, 2025
robot-ch-test-poll2
added
the
pr-synced-to-cloud
Member
|
Let's backport it to 25.10, since CI is broken otherwise |
robot-clickhouse-ci-1
added
pr-backports-created-cloud
robot-clickhouse
added a commit
that referenced
this pull request
Nov 1, 2025
Cherry pick #89038 to 25.10: Prohibit creation of different plain disks with the shared object storage paths
robot-clickhouse
added a commit
that referenced
this pull request
Nov 1, 2025
…with the shared object storage paths
robot-clickhouse
added
the
pr-backports-created
azat
added a commit
that referenced
this pull request
Nov 1, 2025
Backport #89038 to 25.10: Prohibit creation of different plain disks with the shared object storage paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlainRewritabledisks store their file system tree in memory. If another disk changes the object storage structure, the in-memory structure will not be updated, which will lead to invalid file system operations and possible no such key errors.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Prohibit the creation of multiple
plain-rewritabledisks on top of the shared object storage path, as this can lead to undefined behavior during collisions of different metadata storage transactions.