Skip to content

Add check SHOW TABLES access for CREATE TABLE ... AS ... queries.#89052

Merged
pufit merged 3 commits intomasterfrom
pufit/check_show_grant_for_create_as_query
Oct 29, 2025
Merged

Add check SHOW TABLES access for CREATE TABLE ... AS ... queries.#89052
pufit merged 3 commits intomasterfrom
pufit/check_show_grant_for_create_as_query

Conversation

@pufit
Copy link
Copy Markdown
Member

@pufit pufit commented Oct 27, 2025

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Now ClickHouse checks for SHOW TABLES table access when running queries like CREATE TABLE table_new AS table.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Oct 27, 2025

Workflow [PR], commit [97fa8a0]

Summary:

job_name test_name status info comment
Integration tests (amd_asan, old analyzer, 4/6) failure
test_scheduler_cpu_preemptive/test.py::test_downscaling[cpu-slot-preemption-timeout-1ms] FAIL cidb
test_replicated_merge_tree_compatibility/test.py::test_replicated_merge_tree_defaults_compatibility FAIL cidb
OOM in dmesg FAIL cidb
Docker server image failure
docker library image test failure cidb

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 27, 2025
@tuanpach tuanpach self-assigned this Oct 28, 2025
@pufit
Copy link
Copy Markdown
Member Author

pufit commented Oct 29, 2025

Integration tests: #88807

@pufit pufit added pr-improvement Pull request with some product improvements pr-backward-incompatible Pull request with backwards incompatible changes and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Oct 29, 2025
@pufit
Copy link
Copy Markdown
Member Author

pufit commented Oct 29, 2025

Technically, this is backward incompatible because this PR adds a new permission check. However, I believe there shouldn't be any upgrade issues with that.

@pufit pufit added this pull request to the merge queue Oct 29, 2025
Merged via the queue into master with commit 23f8d26 Oct 29, 2025
121 of 124 checks passed
@pufit pufit deleted the pufit/check_show_grant_for_create_as_query branch October 29, 2025 11:09
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 29, 2025
alsugiliazova added a commit to Altinity/clickhouse-regression that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backward-incompatible Pull request with backwards incompatible changes pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants