Refactor text index code a bit#89088
Merged
Ergus merged 5 commits intoClickHouse:masterfrom Oct 28, 2025
Merged
Conversation
* src/Storages/IndicesDescription.{h,cpp} (parseTextIndexArgumentFromAST -> MergeTreeIndexText::parseArgumentsListFromAST) :
(parseTextIndexArgumentsFromAST) : Removed
(getIndexFromAST) : Use the new function MergeTreeIndexText::parseArgumentsListFromAST
(initExpressionInfo) : New function to "group" needed actions to initialize expression.
(parsePositionalArgumentsFromAST) : New function to encapsulate generic arguments parsing
* src/Storages/MergeTree/MergeTreeIndexText.{h,cpp} (parseNamedArgumentFromAST) :
(parseArgumentsListFromAST) : New functions
Contributor
|
Workflow [PR], commit [65bd165] Summary: ❌
|
clickhouse-gh
Bot
added
the
pr-not-for-changelog
Ergus
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
The commend will be added latter
This comment was marked as resolved.
This comment was marked as resolved.
Ergus
commented
Oct 27, 2025
| { | ||
|
|
||
| Tuple MergeTreeIndexText::parseNamedArgumentFromAST(const ASTFunction * ast_equal_function) | ||
| Tuple parseNamedArgumentFromAST(const ASTFunction * ast_equal_function) |
Member
Author
There was a problem hiding this comment.
We could argue forever about these two changes ;)
rschu1ze
approved these changes
Oct 27, 2025
Member
rschu1ze
left a comment
rschu1ze
left a comment
There was a problem hiding this comment.
Alright, let's get this in then.
Member
Author
Member
Author
|
Failing test already reported as flaky: #71049 |
Merged
via the queue into
ClickHouse:master
with commit Oct 28, 2025
589c9ed
122 of 124 checks passed
robot-ch-test-poll4
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Details
Refactors the TextIndex code to make it more localized. This is a preparation for another PR.
Changes made to
src/Storages/IndicesDescription.{h,cpp}andsrc/Storages/MergeTree/MergeTreeIndexText.{h,cpp}: