Skip to content

Avoid possible data-races due to mutable exceptions while parsing Parquet#89174

Merged
azat merged 3 commits intoClickHouse:masterfrom
azat:parquet-mutable-exception-race-fix
Oct 31, 2025
Merged

Avoid possible data-races due to mutable exceptions while parsing Parquet#89174
azat merged 3 commits intoClickHouse:masterfrom
azat:parquet-mutable-exception-race-fix

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Oct 29, 2025 •
edited by clickhouse-gh bot
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Avoid possible data-races due to mutable exceptions while parsing Parquet. Fixes #88385.

@azat azat requested a review from al13n321 October 29, 2025 12:31
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 29, 2025 •
edited
Loading

Workflow [PR], commit [58f6840]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_tsan, 5/6) failure
test_storage_nats/test_nats_jet_stream.py::test_nats_overloaded_insert FAIL cidb, flaky
Install packages (amd_debug) failure
Install clickhouse binary in deb failure cidb
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Oct 29, 2025
al13n321
al13n321 requested changes Oct 29, 2025
View reviewed changes
al13n321
al13n321 reviewed Oct 29, 2025
View reviewed changes
@azat azat marked this pull request as draft October 29, 2025 17:05
@azat azat force-pushed the parquet-mutable-exception-race-fix branch from 76e714c to 58f6840 Compare October 31, 2025 10:32
@azat azat marked this pull request as ready for review October 31, 2025 10:41
al13n321
al13n321 reviewed Oct 31, 2025
View reviewed changes
@azat azat enabled auto-merge October 31, 2025 21:37
@azat azat added this pull request to the merge queue Oct 31, 2025
Merged via the queue into ClickHouse:master with commit 667f351 Oct 31, 2025
120 of 124 checks passed
@azat azat deleted the parquet-mutable-exception-race-fix branch October 31, 2025 22:13
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 31, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Oct 31, 2025
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Oct 31, 2025
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Oct 31, 2025
@robot-clickhouse-ci-1
Merge pull request #89346 from ClickHouse/cherrypick/25.8/89174
9d4a144 
Cherry pick #89174 to 25.8: Avoid possible data-races due to mutable exceptions while parsing Parquet
robot-clickhouse added a commit that referenced this pull request Oct 31, 2025
@robot-clickhouse
Backport #89174 to 25.8: Avoid possible data-races due to mutable exc…
0c272ae 
…eptions while parsing Parquet
This was referenced Oct 31, 2025
Merged
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Oct 31, 2025
@robot-clickhouse-ci-1
Merge pull request #89348 from ClickHouse/cherrypick/25.10/89174
f38a954 
Cherry pick #89174 to 25.10: Avoid possible data-races due to mutable exceptions while parsing Parquet
robot-clickhouse added a commit that referenced this pull request Oct 31, 2025
@robot-clickhouse
Backport #89174 to 25.10: Avoid possible data-races due to mutable ex…
854cb11 
…ceptions while parsing Parquet
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Oct 31, 2025
Merged
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 1, 2025
clickhouse-gh bot added a commit that referenced this pull request Nov 1, 2025
@clickhouse-gh
Merge pull request #89349 from ClickHouse/backport/25.10/89174
f2b8adf 
Backport #89174 to 25.10: Avoid possible data-races due to mutable exceptions while parsing Parquet
azat added a commit that referenced this pull request Nov 1, 2025
@azat
Merge pull request #89347 from ClickHouse/backport/25.8/89174
d687ab2 
Backport #89174 to 25.8: Avoid possible data-races due to mutable exceptions while parsing Parquet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@al13n321 al13n321 al13n321 approved these changes

Assignees

No one assigned

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.8-must-backport v25.10-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data-race due to mutable exceptions and std::rethrow_exception

5 participants

@azat @al13n321 @robot-clickhouse @robot-ch-test-poll2 @robot-ch-test-poll4