Fix submodules#89193
Merged
azat merged 2 commits intoClickHouse:masterfrom Oct 29, 2025
Merged
Conversation
Not always github allows to fetch via upstream repo, sometimes it gives
"fatal: Fetched in submodule path 'contrib/zstd', but it did not contain
X." error [1].
fatal: transport 'file' not allowed
fatal: Fetched in submodule path 'contrib/zstd', but it did not contain 437081852c396eeb61edb7d47044d8cad911885e. Direct fetching of that commit failed.
Refs:
- ClickHouse/zstd#2
- ClickHouse/thrift#2
Contributor
|
Workflow [PR], commit [a34e59d] Summary: ❌
|
clickhouse-gh
Bot
added
the
pr-not-for-changelog
al13n321
approved these changes
Oct 29, 2025
Member
al13n321
left a comment
al13n321
left a comment
There was a problem hiding this comment.
Oooh, that's what causes that error, nice, I was assuming github is just generally flaky, good to know there's a more specific cause, thanks for fixing. I'll pay attention to this when updating submodules from now on.
Merged
via the queue into
ClickHouse:master
with commit Oct 29, 2025
4109f41
120 of 124 checks passed
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Details
Not always github allows to fetch via upstream repo, sometimes it gives "fatal: Fetched in submodule path 'contrib/zstd', but it did not contain X." error.
Refs: