Fix L2DistanceTransposed unexpected return type when input is LowCardinality(Nullable(T))#89397
Merged
Fix L2DistanceTransposed unexpected return type when input is LowCardinality(Nullable(T))#89397
L2DistanceTransposed unexpected return type when input is LowCardinality(Nullable(T))#89397Conversation
Contributor
|
Workflow [PR], commit [878eebb] Summary: ❌
|
clickhouse-gh
bot
added
pr-critical-bugfix
pr-must-backport
Avogar
approved these changes
Nov 3, 2025
Member
Author
|
Red CI is because of #89409 |
robot-ch-test-poll1
added
pr-synced-to-cloud
This was referenced Nov 3, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
Nov 3, 2025
Cherry pick #89397 to 25.10: Fix `L2DistanceTransposed` unexpected return type when input is `LowCardinality(Nullable(T))`
robot-clickhouse
added a commit
that referenced
this pull request
Nov 3, 2025
…n type when input is `LowCardinality(Nullable(T))`
robot-ch-test-poll2
added
the
pr-backports-created
clickhouse-gh bot
added a commit
that referenced
this pull request
Nov 3, 2025
Backport #89397 to 25.10: Fix `L2DistanceTransposed` unexpected return type when input is `LowCardinality(Nullable(T))`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix LOGICAL_ERROR in L2DistanceTransposed(vec1, vec2, p) where the optimization for partial QBit reading incorrectly removed Nullable from the return type when p was LowCardinality(Nullable(T)). Resolves #88362.
Details
Fixes #88362