Skip to content

Enable allow_special_serialization_kinds_in_output_formats by default#89402

Merged
Avogar merged 4 commits intomasterfrom
Avogar-patch-8
Nov 11, 2025
Merged

Enable allow_special_serialization_kinds_in_output_formats by default#89402
Avogar merged 4 commits intomasterfrom
Avogar-patch-8

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Nov 3, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Enable setting allow_special_serialization_kinds_in_output_formats by default. It will lead to less memory usage and improve query speed of output of Sparse/Replicated columns in some row output formats.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 3, 2025

Workflow [PR], commit [b33a552]

Summary:

job_name test_name status info comment
Stateless tests (amd_asan, distributed plan, parallel, 1/2) failure
01018_Distributed__shard_num FAIL cidb
Upgrade check (amd_msan) failure
Killed by signal (in clickhouse-server.log) FAIL cidb
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL cidb
Killed by signal (output files) FAIL cidb
Found signal in gdb.log FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Nov 3, 2025
@Algunenano Algunenano self-assigned this Nov 3, 2025
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it might make sense to put it into a more prominent place (breaking change or something as notable) since I expect some clients might not be compatible with the "new" output, right?

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Nov 3, 2025

some clients might not be compatible with the "new" output, right?

We have a check for old client version in Native writer:

if (client_revision < DBMS_MIN_REVISION_WITH_REPLICATED_SERIALIZATION)
result_column = result_column->convertToFullColumnIfReplicated();
if (client_revision < DBMS_MIN_REVISION_WITH_SPARSE_SERIALIZATION)
result_column = recursiveRemoveSparse(result_column);

@Algunenano
Copy link
Copy Markdown
Member

We have a check for old client version in Native writer:

Nice! I didn't see it

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Nov 11, 2025

Upgrade check (amd_msan) - #89853
Stateless tests (amd_asan, distributed plan, parallel, 1/2) - test 01018_Distributed__shard_num failed with Coordination::Exception: Coordination error: No node, didn't find any similar failures of this test but it seems to be unrelated to the changes.

@Avogar Avogar added this pull request to the merge queue Nov 11, 2025
Merged via the queue into master with commit 9877153 Nov 11, 2025
128 of 131 checks passed
@Avogar Avogar deleted the Avogar-patch-8 branch November 11, 2025 13:59
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants