Remove duplicated filesystem caches from asynchronous metrics, SYSTEM queries#89640
Merged
azat merged 1 commit intoClickHouse:masterfrom Nov 14, 2025
Merged
Remove duplicated filesystem caches from asynchronous metrics, SYSTEM queries#89640azat merged 1 commit intoClickHouse:masterfrom
azat merged 1 commit intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [01bacf6] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-improvement
kssenii
reviewed
Nov 14, 2025
kssenii
approved these changes
Nov 14, 2025
kssenii
added
the
pr-must-backport
… queries It is possible to have filesystem cache i.e. "a" and "b", that points to the same path. Previously those was accounted multiple times in FilesystemCacheBytes from system.asynchronous_metrics, which is wrong. Also SYSTEM queries executed actions on the same caches multiple times in this case, which is redundant. Plus system.filesystem_caches may report different set of files for various caches even though they share the same path, fix this as well.
azat
force-pushed
the
unique-filesystem-caches
branch
from
e7fdae1 to
01bacf6
Compare
Merged
via the queue into
ClickHouse:master
with commit Nov 14, 2025
ea95cb1
127 of 130 checks passed
robot-ch-test-poll2
added
the
pr-synced-to-cloud
robot-clickhouse-ci-2
added
the
pr-must-backport-synced
robot-ch-test-poll
added a commit
that referenced
this pull request
Nov 14, 2025
Cherry pick #89640 to 25.8: Remove duplicated filesystem caches from asynchronous metrics, SYSTEM queries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 14, 2025
…nchronous metrics, SYSTEM queries
robot-ch-test-poll
added a commit
that referenced
this pull request
Nov 14, 2025
Cherry pick #89640 to 25.9: Remove duplicated filesystem caches from asynchronous metrics, SYSTEM queries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 14, 2025
…nchronous metrics, SYSTEM queries
robot-ch-test-poll
added a commit
that referenced
this pull request
Nov 14, 2025
Cherry pick #89640 to 25.10: Remove duplicated filesystem caches from asynchronous metrics, SYSTEM queries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 14, 2025
…ynchronous metrics, SYSTEM queries
clickhouse-gh bot
added a commit
that referenced
this pull request
Nov 14, 2025
Backport #89640 to 25.10: Remove duplicated filesystem caches from asynchronous metrics, SYSTEM queries
azat
added a commit
that referenced
this pull request
Nov 16, 2025
Backport #89640 to 25.9: Remove duplicated filesystem caches from asynchronous metrics, SYSTEM queries
azat
added a commit
that referenced
this pull request
Nov 16, 2025
Backport #89640 to 25.8: Remove duplicated filesystem caches from asynchronous metrics, SYSTEM queries
robot-clickhouse-ci-2
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix wrong
FilesystemCacheBytes(and others) insystem.asynchronous_metrics. RunSYSTEMqueries on filesystem caches only once. Atomic view for caches that points to the same path insystem.filesystem_caches.Details
It is possible to have filesystem cache i.e. "a" and "b", that points to the same path.
Previously those was accounted multiple times in
FilesystemCacheBytesfromsystem.asynchronous_metrics, which is wrong.Also
SYSTEMqueries executed actions on the same caches multiple times in this case, which is redundant.Plus
system.filesystem_cachesmay report different set of files for various caches even though they share the same path, fix this as well.