CI: Collect and export coverage data for Functional tests#89671
Merged
CI: Collect and export coverage data for Functional tests#89671
Conversation
Contributor
clickhouse-gh
Bot
added
the
pr-not-for-changelog
maxknv
force-pushed
the
ci_coverage_test_to_nightly
branch
13 times, most recently
from
8ddb5ad to
c1f07dc
Compare
maxknv
force-pushed
the
ci_coverage_test_to_nightly
branch
from
c1f07dc to
392db3b
Compare
maxknv
changed the title
maxknv
changed the title
leshikus
approved these changes
Nov 10, 2025
Contributor
There was a problem hiding this comment.
Looks great, though there may be many issues when we start using this. For example, the coverage_log is optimized for test lookups, and not symbol lookups. I'm not even sure that we can consider symbols as LowCardinality, there are likely more than 10000 functions in clickhouse (if these are c++ functions in the source code, not sql functions)
Member
|
I never touched coverage, can't contribute here |
robot-ch-test-poll4
added
the
pr-synced-to-cloud
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Details
This PR implements coverage-per-test data exporting for Functional tests. This data is supposed to be used later to find most relevant test cases for a PR/change.
Adds coverage flavor for functional tests job - run all tests sequentially, store data into local system table and then export to the cidb cluster (table)
Adds coverage job into nightly workflow
Adds script to retrieve changed symbols from pr diff (to later map symbols onto test names)
example: python ./ci/jobs/scripts/pr_diff_to_symbols.py 89795 ./ci/clickhouseupdates aws cli in test's docker image
removes coverage job from master workflow (deprecated by the change)
removes exporting coverage to ci log cluster (deprecated by the change)