Skip to content

Fix theilsU and contingency computation#89760

Merged
nihalzp merged 11 commits intoClickHouse:masterfrom
nihalzp:fix-theilsu-contingency
Dec 16, 2025
Merged

Fix theilsU and contingency computation#89760
nihalzp merged 11 commits intoClickHouse:masterfrom
nihalzp:fix-theilsu-contingency

Conversation

@nihalzp
Copy link
Copy Markdown
Member

@nihalzp nihalzp commented Nov 8, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix bugs in the theilsU and contingency functions that caused incorrect results.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Details

:) SELECT theilsU(number, number) FROM numbers(5)

   ┌─theilsU(number, number)─┐
1. │                      -1<- should be 1
   └─────────────────────────┘
:) SELECT contingency(number, number) FROM numbers(5)

   ┌─contingency(number, number)─┐
1. │          0.6666666666666666<- should be 0.8944271909999159
   └─────────────────────────────┘

Prerequisite for #83521

@nihalzp nihalzp marked this pull request as ready for review November 8, 2025 12:13
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 8, 2025

Workflow [PR], commit [085d07a]

Summary:

job_name test_name status info comment
Integration tests (amd_tsan, 1/6) failure
test_storage_nats/test_nats_jet_stream.py::test_nats_overloaded_insert FAIL cidb, issue
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting in Function_arrayElement: the query: FAIL cidb, issue

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Nov 8, 2025
@nikitamikhaylov nikitamikhaylov self-assigned this Nov 10, 2025
@nihalzp nihalzp requested review from nikitamikhaylov and removed request for nikitamikhaylov December 12, 2025 06:41
@nihalzp nihalzp added this pull request to the merge queue Dec 16, 2025
Merged via the queue into ClickHouse:master with commit 340d573 Dec 16, 2025
250 of 256 checks passed
@nihalzp nihalzp deleted the fix-theilsu-contingency branch December 16, 2025 18:30
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants