Skip to content

fix paimon table function with no partition#89793

Merged
bharatnc merged 13 commits intoClickHouse:masterfrom
JiaQiTang98:fix-paimon-no-partition
Nov 18, 2025
Merged

fix paimon table function with no partition#89793
bharatnc merged 13 commits intoClickHouse:masterfrom
JiaQiTang98:fix-paimon-no-partition

Conversation

@JiaQiTang98
Copy link
Copy Markdown
Contributor

@JiaQiTang98 JiaQiTang98 commented Nov 10, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixed Paimon table function handling for tables with no partition. Resolves #89690

Details

Resolves #89690

@JiaQiTang98 JiaQiTang98 added the can be tested Allows running workflows for external contributors label Nov 10, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 10, 2025

Workflow [PR], commit [b059669]

Summary:

job_name test_name status info comment
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb
BuzzHouse (amd_ubsan) failure
Logical error: 'false && "WriteBuffer is neither finalized nor canceled in destructor."'. FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Nov 10, 2025
@bharatnc bharatnc self-assigned this Nov 10, 2025
@JiaQiTang98
Copy link
Copy Markdown
Contributor Author

JiaQiTang98 commented Nov 10, 2025

test_s3_access_headers/test.py::test_custom_access_header[test_access_over_custom_header]

#89758

Bugfix validation (functional tests)

Seems the test succeeded, but the CI failed.

@hanfei1991 hanfei1991 self-assigned this Nov 11, 2025
@hanfei1991
Copy link
Copy Markdown
Member

@JiaQiTang98
Copy link
Copy Markdown
Contributor Author

Looks like the new test cannot cover the bug: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=89793&sha=6571858a7a92d0940cbac92e6672773a3b96a8d6&name_0=PR&name_1=Bugfix+validation+%28functional+tests%29

Seems S3 is not influenced by this issue, I have changed the test case to use paimonLocal instead; however, the bugfix CI has some errors. I will rerun after this PR is merged: #89873

@JiaQiTang98
Copy link
Copy Markdown
Contributor Author

03701_paimon_no_partition should fail during Bugfix validation (functional tests), and it did fail—so I'm not sure why the CI failed.

@JiaQiTang98
Copy link
Copy Markdown
Contributor Author

@bharatnc
Copy link
Copy Markdown
Contributor

03701_paimon_no_partition should fail during Bugfix validation (functional tests), and it did fail—so I'm not sure why the CI failed.

I don't see this failure anymore. So I think we can merge.

@bharatnc bharatnc added this pull request to the merge queue Nov 18, 2025
Merged via the queue into ClickHouse:master with commit 356392b Nov 18, 2025
129 of 132 checks passed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

paimonHDFS did not work when paimon table is not PARTITIONED

4 participants