add a list of tables to flush in FLUSH ASYNC QUEUE#89915
Merged
Conversation
Member
Author
|
It is needed for #89140 |
Contributor
|
Workflow [PR], commit [8731fbd] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-improvement
antaljanosbenjamin
assigned
antaljanosbenjamin and
Algunenano and unassigned
Algunenano and
antaljanosbenjamin
Member
antaljanosbenjamin
left a comment
antaljanosbenjamin
left a comment
There was a problem hiding this comment.
I will leave this PR to @Algunenano as github didn't handle the parallel lock properly, but I will leave my already written comments.
| auto database_table_name_set = std::set<std::pair<String, String>>{}; | ||
| for (const auto & full_table_name : table_names) | ||
| { | ||
| auto dot_pos = full_table_name.find('.'); |
Member
There was a problem hiding this comment.
Will this work with quoted names, e.g.: `this.is.a.valid.databasename`.table?
Member
Author
There was a problem hiding this comment.
good point, will add a test.
Member
Author
There was a problem hiding this comment.
It does not work unfortunatly
tests/queries/0_stateless/03708_flush_async_insert_queue_for_table.sql
Outdated
Show resolved
Hide resolved
CheSema
force-pushed
the
chesema-flush-async-queue-for-table
branch
from
47d9c59 to
96b097d
Compare
CheSema
force-pushed
the
chesema-flush-async-queue-for-table
branch
from
96b097d to
37610b0
Compare
antaljanosbenjamin
approved these changes
Nov 13, 2025
Member
Author
|
Stress test (amd_ubsan) Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) |
robot-ch-test-poll4
added
the
pr-synced-to-cloud
xiaohuanlin
added a commit
to xiaohuanlin/ClickHouse
that referenced
this pull request
Apr 10, 2026
Adds a new top-level config option `replica_host` that specifies the hostname other replicas should use to reach this server. This is useful when the FQDN returned by `getFQDNOrHostName()` or `interserver_http_host` does not match the hostname used for inter-replica communication (e.g. in containerized or NATed environments). Fallback chain in `getHostID`: 1. `replica_host` (if configured) 2. `interserver_http_host` (existing behavior) Closes ClickHouse#89915
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
added a possibility to set a list of tables to flush in command
system flush async insert queue.Documentation entry for user-facing changes