Fix escaping for some SHOW queries#89942
Merged
alexey-milovidov merged 6 commits intomasterfrom Nov 14, 2025
Merged
Conversation
(cherry picked from commit 08dc90b736b9fe29e662a12dd04a6d461dd5af1c)
Contributor
|
Workflow [PR], commit [fabd077] Summary: ❌
|
Member
|
With the SQLite database created on top of a prepared .sqlite3 file? |
Member
Author
|
@alexey-milovidov which query you need to write in clickhouse-client to trigger this logic? You cannot specify arbitrary string as table name. |
Member
|
According to the code, it will be EXISTS TABLE from the SQLite database. |
Member
Author
|
@alexey-milovidov our parser will not allow you to type arbitrary string in |
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
Member
|
Identifiers can be arbitrary non-empty strings. |
Member
|
|
Member
|
FYI, "Bugfix validation" shows that the new tests pass on the master branch. If it's not the case, ask our CI team. |
alexey-milovidov
approved these changes
Nov 14, 2025
robot-ch-test-poll1
added a commit
that referenced
this pull request
Nov 14, 2025
Cherry pick #89942 to 25.3: Fix escaping for some `SHOW` queries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 14, 2025
This was referenced Nov 14, 2025
robot-ch-test-poll1
added a commit
that referenced
this pull request
Nov 14, 2025
Cherry pick #89942 to 25.8: Fix escaping for some `SHOW` queries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 14, 2025
This was referenced Nov 14, 2025
robot-ch-test-poll1
added a commit
that referenced
this pull request
Nov 14, 2025
Cherry pick #89942 to 25.9: Fix escaping for some `SHOW` queries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 14, 2025
This was referenced Nov 14, 2025
robot-ch-test-poll1
added a commit
that referenced
this pull request
Nov 14, 2025
Cherry pick #89942 to 25.10: Fix escaping for some `SHOW` queries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 14, 2025
clickhouse-gh bot
added a commit
that referenced
this pull request
Nov 14, 2025
Backport #89942 to 25.10: Fix escaping for some `SHOW` queries
clickhouse-gh bot
added a commit
that referenced
this pull request
Nov 14, 2025
Backport #89942 to 25.9: Fix escaping for some `SHOW` queries
alexey-milovidov
added a commit
that referenced
this pull request
Nov 17, 2025
Backport #89942 to 25.8: Fix escaping for some `SHOW` queries
alexey-milovidov
added a commit
that referenced
this pull request
Nov 17, 2025
Backport #89942 to 25.3: Fix escaping for some `SHOW` queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix wrong escaping for
SHOW COLUMNSandSHOW FUNCTIONSqueries.