Fix logical error with join_using_top_level_identifier

[vdimir]

Linked issues

• fixes https://github.com/ClickHouse/clickhouse-core-incidents/issues/1078

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix possible logical error when using analyzer_compatibility_join_using_top_level_identifier with multiple joins.

[clickhouse-gh]

Workflow [PR], commit [62cab13]

Summary: ❌

job_name	test_name	status	info	comment
BuzzHouse (amd_debug)		failure
	Logical error: 'Inconsistent AST formatting: the query:	FAIL	cidb
BuzzHouse (amd_ubsan)		failure
	Received signal 17	FAIL	cidb

[vdimir]

BuzzHouse (amd_debug)

https://github.com/ClickHouse/ClickHouse/issues/90002

BuzzHouse (amd_ubsan)

Cannot add action to empty ExpressionActionsChain
https://github.com/ClickHouse/ClickHouse/issues/88150

[tavplubix]

@vdimir this failure is suspicious: CI DB

First time it happened in this PR, and then it started failing everywhere once it was merged on 2025-11-19

[vdimir]

@vdimir this failure is suspicious: CI DB

First time it happened in this PR, and then it started failing everywhere once it was merged on 2025-11-19

This is a relevant issue, sorry for disturbing CI and thanks for pointing it out.

I don't see a point in reverting the PR, since the same query would otherwise fail with another LOGICAL_ERROR. We could revert/remove just the test for now, but I'll check if I can make a proper fix promptly.