Skip to content

Do not assert on unknown job names while building ClickHouse#90263

Merged
antaljanosbenjamin merged 1 commit intomasterfrom
remove-assert-for-submodule-checkout
Nov 18, 2025
Merged

Do not assert on unknown job names while building ClickHouse#90263
antaljanosbenjamin merged 1 commit intomasterfrom
remove-assert-for-submodule-checkout

Conversation

@antaljanosbenjamin
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin commented Nov 18, 2025

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Details

This assert caused issues in private repo. As a result I changed the script to have a list of jobs that don't use the script, all other jobs (including private repo) will use the script to checkout submodules.

This assert caused issues in private repo. As a result I changed the script to have a list of jobs that don't use the script, all other jobs (including private repo) will use the script to checkout submodules.
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Nov 18, 2025

Workflow [PR], commit [da135cd]

Summary:

job_name test_name status info comment
AST fuzzer (amd_ubsan) failure
Logical error: 'Bad cast from type DB::ColumnConst to DB::ColumnVariant'. FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb
BuzzHouse (arm_asan) failure
Let op! ERROR cidb
BuzzHouse (amd_ubsan) failure
Let op! ERROR cidb

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 18, 2025
@maxknv maxknv self-assigned this Nov 18, 2025
@maxknv maxknv self-requested a review November 18, 2025 10:25
@antaljanosbenjamin
Copy link
Copy Markdown
Member Author

Most of the builds are done, let's merge this.

@antaljanosbenjamin antaljanosbenjamin added this pull request to the merge queue Nov 18, 2025
Merged via the queue into master with commit 3963774 Nov 18, 2025
93 of 131 checks passed
@antaljanosbenjamin antaljanosbenjamin deleted the remove-assert-for-submodule-checkout branch November 18, 2025 12:18
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants