Fix aggregated projections

[antaljanosbenjamin]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix some queries with aggregated projection optimization.

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

[clickhouse-gh]

Workflow [PR], commit [833d2df]

Summary: ❌

job_name	test_name	status	info	comment
Stateless tests (arm_asan, targeted)		failure
	02151_lc_prefetch	FAIL	cidb
	01459_manual_write_to_replicas_quorum_detach_attach	FAIL	cidb, flaky
	01459_manual_write_to_replicas_quorum_detach_attach	FAIL	cidb, flaky
	01459_manual_write_to_replicas_quorum_detach_attach	FAIL	cidb, flaky
	01459_manual_write_to_replicas_quorum_detach_attach	FAIL	cidb, flaky
Stateless tests (amd_msan, parallel)		failure
	03403_mv_errors	FAIL	cidb
	00596_limit_on_expanded_ast	FAIL	cidb
Integration tests (amd_asan, db disk, old analyzer, 3/6)		failure
	test_restore_db_replica/test.py::test_restore_db_replica_with_diffrent_table_metadata[restore node1-node2]	FAIL	cidb, flaky
Integration tests (amd_tsan, 1/6)		failure
	test_storage_s3_queue/test_parallel_inserts.py::test_parallel_inserts_with_failures[1]	FAIL	cidb, flaky
Stress test (amd_ubsan)		failure
	Server died	FAIL	cidb
	Hung check failed, possible deadlock found (see hung_check.log)	FAIL	cidb
	Killed by signal (in clickhouse-server.log)	FAIL	cidb
	Fatal message in clickhouse-server.log (see fatal_messages.txt)	FAIL	cidb
	Killed by signal (output files)	FAIL	cidb
	Found signal in gdb.log	FAIL	cidb
BuzzHouse (amd_debug)		failure
	Logical error: 'Inconsistent AST formatting: the query:	FAIL	cidb
BuzzHouse (amd_tsan)		failure
	Logical error: '(isConst()		isSparse()
BuzzHouse (amd_msan)		failure
	Received signal 17	FAIL	cidb
Performance Comparison (amd_release, master_head, 3/6)		failure
	Start	failure

[Copilot]

Pull Request Overview

This PR fixes a bug in aggregated projection optimization where virtual columns were being added incorrectly to the ActionsDAG, causing crashes or incorrect behavior in certain queries involving projections with joins and window functions.

Key changes:

• Modified how virtual columns are added to the ActionsDAG in projection optimization to use name and type separately instead of passing a NameAndTypePair object
• Added a temporary safeguard in ActionsDAG::addNode to prevent invalid column objects from being stored
• Added a regression test with a complex query involving CTEs, window functions, and joins

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/Processors/QueryPlan/Optimizations/optimizeUseAggregateProjection.cpp	Fixed virtual column input addition to use separate name and type parameters
src/Interpreters/ActionsDAG.cpp	Added validation to clear invalid column objects in non-placeholder nodes
tests/queries/0_stateless/03721_aggregate_projection_actions_dag.sql	Added regression test with complex query involving CTEs, window functions and joins
tests/queries/0_stateless/03721_aggregate_projection_actions_dag.reference	Expected output showing the query plan structure

[antaljanosbenjamin]

• amd_compat - Build (amd_compat) is broken #90492
• 01459_manual_write_to_replicas_quorum_detach_attach - flaky
• 01079_parallel_alter_detach_table_zookeeper - flaky
• 03249_dynamic_alter_consistency - flaky

[antaljanosbenjamin]

• amd_compat - Build (amd_compat) is broken #90492
• 01459_manual_write_to_replicas_quorum_detach_attach - flaky
• test_ssh/test.py::test_paramiko_password - Revert "Keeper compatibility with zookeeper: create with statistics" #90572
• Stress test - Unexpected return type from concat. Expected String. Got Nullable(String) #87016 (not exactly, but I am sure it roots down to the same issue)

[antaljanosbenjamin]

Test failures are not related.