Skip to content

Disable LOGICAL_ERRORs about function monotonicity in release build#90462

Merged
al13n321 merged 2 commits intomasterfrom
bandaid
Nov 28, 2025
Merged

Disable LOGICAL_ERRORs about function monotonicity in release build#90462
al13n321 merged 2 commits intomasterfrom
bandaid

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Nov 20, 2025

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Details

I recently added these two LOGICAL_ERRORs that exposed some preexisting bugs: #90461. I'm in the middle of making a stress test to hopefully find and fix most of these bugs. Until that is done, here's a PR to go back to ignoring them for now.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Nov 20, 2025

Workflow [PR], commit [e84e147]

Summary:

job_name test_name status info comment
Build (amd_compat) failure
Cmake configuration failure cidb
Stateless tests (amd_asan, distributed plan, parallel, 1/2) failure
02843_context_has_expired FAIL cidb
Stateless tests (amd_tsan, s3 storage, parallel) failure
00938_fix_rwlock_segfault_long FAIL cidb, flaky
Integration tests (amd_tsan, 3/6) failure
test_ssh/test.py::test_paramiko_password FAIL cidb
AST fuzzer (amd_debug) failure
Logical error: 'Invalid number of rows in Chunk Nullable(size = 3, UInt8(size = 3), UInt8(size = 3)) Tuple(size = 1) Int32(size = 3) column Tuple() at position 1: expected 3, got 1'. FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 20, 2025
@Algunenano Algunenano self-assigned this Nov 20, 2025
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my favorite kind of asserts, as it's finding multiple bugs and preventing further issues. I hope we can enable it back again in release builds too

@al13n321 al13n321 enabled auto-merge November 20, 2025 19:25
@al13n321 al13n321 added this pull request to the merge queue Nov 28, 2025
Merged via the queue into master with commit c7d5d54 Nov 28, 2025
125 of 132 checks passed
@al13n321 al13n321 deleted the bandaid branch November 28, 2025 18:58
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 28, 2025
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Nov 28, 2025
robot-clickhouse added a commit that referenced this pull request Nov 28, 2025
robot-clickhouse added a commit that referenced this pull request Nov 28, 2025
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 28, 2025
al13n321 pushed a commit that referenced this pull request Dec 2, 2025
…onicity in release build (#91146)

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
al13n321 pushed a commit that referenced this pull request Dec 2, 2025
…onicity in release build (#91148)

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo v25.10-must-backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants