Skip to content

Eagerly free vector similarity index cache entries when parts are dropped#90750

Merged
shankar-iyer merged 7 commits intoClickHouse:masterfrom
shankar-iyer:vector_index_cache_on_drop_part
Nov 26, 2025
Merged

Eagerly free vector similarity index cache entries when parts are dropped#90750
shankar-iyer merged 7 commits intoClickHouse:masterfrom
shankar-iyer:vector_index_cache_on_drop_part

Conversation

@shankar-iyer
Copy link
Copy Markdown
Member

@shankar-iyer shankar-iyer commented Nov 24, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Entries in the vector similarity index cache are now removed when table parts are dropped or replaced by newer parts. Prior to this, these would be cleared only lazily by cache eviction.

@shankar-iyer shankar-iyer marked this pull request as draft November 24, 2025 17:26
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 24, 2025

Workflow [PR], commit [75ac34b0]

Summary:

job_name test_name status info comment
Stateless tests (arm_asan, targeted) failure
00596_limit_on_expanded_ast FAIL cidb
00596_limit_on_expanded_ast FAIL cidb
00596_limit_on_expanded_ast FAIL cidb
00596_limit_on_expanded_ast FAIL cidb
00596_limit_on_expanded_ast FAIL cidb
00596_limit_on_expanded_ast FAIL cidb
00596_limit_on_expanded_ast FAIL cidb
00596_limit_on_expanded_ast FAIL cidb
02354_vector_search_expansion_search FAIL cidb
00596_limit_on_expanded_ast FAIL cidb
1 more test cases not shown
Stateless tests (amd_msan, parallel) failure
00816_long_concurrent_alter_column FAIL cidb
Integration tests (arm_binary, distributed plan, 2/4) failure
test_refreshable_mv/test.py::test_refreshable_mv_in_read_only_node_no_ddl FAIL cidb
test_refreshable_mv/test.py::test_refresh_vs_shutdown_smoke FAIL cidb
test_refreshable_mv/test.py::test_pause FAIL cidb
test_refreshable_mv/test.py::test_backup_outer_table FAIL cidb
test_refreshable_mv/test.py::test_backup_inner_table FAIL cidb
test_refreshable_mv/test.py::test_adding_replica FAIL cidb
test_refreshable_mv/test.py::test_replicated_db_startup_race FAIL cidb
Upgrade check (amd_msan) failure
Killed by signal (in clickhouse-server.log) FAIL cidb
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL cidb
Killed by signal (output files) FAIL cidb
Found signal in gdb.log FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb
Performance Comparison (amd_release, master_head, 4/6) failure
Start failure
Performance Comparison (amd_release, master_head, 5/6) failure
Start failure
Performance Comparison (amd_release, master_head, 6/6) failure
Start failure

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Nov 24, 2025
@shankar-iyer shankar-iyer marked this pull request as ready for review November 25, 2025 11:15
@rschu1ze rschu1ze changed the title Free vector similarity index cache entries when parts are dropped Eagerly free vector similarity index cache entries when parts are dropped Nov 26, 2025
@shankar-iyer shankar-iyer added this pull request to the merge queue Nov 26, 2025
Merged via the queue into ClickHouse:master with commit 4a95723 Nov 26, 2025
111 of 129 checks passed
@shankar-iyer shankar-iyer deleted the vector_index_cache_on_drop_part branch November 26, 2025 11:47
robot-clickhouse added a commit that referenced this pull request Nov 26, 2025
Cherry pick #90750 to 25.10: Eagerly free vector similarity index cache entries when parts are dropped
robot-clickhouse added a commit that referenced this pull request Nov 26, 2025
robot-clickhouse added a commit that referenced this pull request Nov 26, 2025
Cherry pick #90750 to 25.11: Eagerly free vector similarity index cache entries when parts are dropped
robot-clickhouse added a commit that referenced this pull request Nov 26, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 26, 2025
clickhouse-gh bot added a commit that referenced this pull request Nov 26, 2025
Backport #90750 to 25.11: Eagerly free vector similarity index cache entries when parts are dropped
tavplubix added a commit that referenced this pull request Nov 26, 2025
tavplubix added a commit that referenced this pull request Nov 26, 2025
…/90750

Revert "Backport #90750 to 25.11: Eagerly free vector similarity index cache entries when parts are dropped"
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-synced-to-cloud The PR is synced to the cloud repo pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-improvement Pull request with some product improvements pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.10-must-backport v25.11-must-backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants