Disable parallel replicas for RIGHT JOIN with distributed table on right side#90806
Merged
nickitat merged 6 commits intoClickHouse:masterfrom Dec 1, 2025
Merged
Disable parallel replicas for RIGHT JOIN with distributed table on right side#90806nickitat merged 6 commits intoClickHouse:masterfrom
nickitat merged 6 commits intoClickHouse:masterfrom
Conversation
vdimir
added
the
can be tested
Contributor
|
Workflow [PR], commit [1c5cdf2] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-bugfix
zoomxi
force-pushed
the
duplicate_right_join
branch
from
fd89f22 to
3afee44
Compare
Contributor
Author
|
Stateless tests (arm_asan, targeted) Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) Stateless tests (amd_msan, parallel) Stress test (arm_asan, s3) Others are also unrelated to this pr. |
zoomxi
force-pushed
the
duplicate_right_join
branch
from
3afee44 to
a4d5499
Compare
Member
|
The provided test fails to reproduce the issue. Pls find another one. |
zoomxi
force-pushed
the
duplicate_right_join
branch
2 times, most recently
from
8ee4031 to
98d31ba
Compare
zoomxi
force-pushed
the
duplicate_right_join
branch
from
98d31ba to
9cfea42
Compare
Contributor
Author
|
|
Member
unfortunately, yes. should be fixed by #91094 |
nickitat
approved these changes
Nov 28, 2025
Merged
via the queue into
ClickHouse:master
with commit Dec 1, 2025
1839a50
124 of 130 checks passed
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix duplicate data issue in RIGHT JOIN with distributed table when parallel replicas enabled.
Details
When RIGHT JOIN with a distributed table on the right side, the distributed table would be wrapped into a subquery, causing parallel replicas to incorrectly choose the left table for parallel reading, and each replica would then independently read the distributed table, resulting in duplicate data.