Skip to content

Change default of settings check_query_single_value_result#91009

Merged
rschu1ze merged 5 commits intomasterfrom
check_query_single_value_result-2
Dec 10, 2025
Merged

Change default of settings check_query_single_value_result#91009
rschu1ze merged 5 commits intomasterfrom
check_query_single_value_result-2

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Nov 27, 2025

This is a re-submit of #90150 which was reverted by #90815

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Changed the default of setting check_query_single_value_result from true to false. This causes CHECK TABLE to return detailed per-part results instead of an aggregated result (1 = okay, 0 = errors found). Compared to the previous behavior, this is likely more aligned with what the user wants.

@rschu1ze rschu1ze changed the title Change default of settings check_query_single_value_result Change default of settings check_query_single_value_result Nov 27, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 27, 2025

Workflow [PR], commit [f44423f]

Summary:

job_name test_name status info comment
Integration tests (amd_asan, flaky) failure
test_merge_tree_azure_blob_storage/test.py::test_endpoint[3-3] FAIL cidb
test_merge_tree_azure_blob_storage/test.py::test_endpoint[2-3] FAIL cidb
Stateless tests (arm_binary, parallel) failure
03735_excessive_buffer_flush FAIL cidb
Integration tests (amd_tsan, 1/6) failure
test_storage_nats/test_nats_jet_stream.py::test_nats_overloaded_insert FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Nov 27, 2025
@tiandiwonder tiandiwonder requested a review from Copilot November 28, 2025 01:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the default value of the check_query_single_value_result setting from true to false. This means CHECK TABLE will now return detailed per-part results by default instead of a single aggregated value (1 for success, 0 for errors).

Key changes:

  • Updated the default setting value in src/Core/Settings.cpp
  • Added entry to settings change history in src/Core/SettingsChangesHistory.cpp
  • Updated documentation to reflect the new default behavior
  • Modified 19 test files to explicitly set check_query_single_value_result = 1 to maintain their existing test behavior

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Core/Settings.cpp Changed default value of check_query_single_value_result from true to false
src/Core/SettingsChangesHistory.cpp Added changelog entry for the setting change
docs/en/sql-reference/statements/check-table.md Updated documentation to reflect new default and improved clarity
tests/queries/0_stateless/*.{sh,sql} Added explicit setting to preserve existing test behavior expecting single-value results
tests/integration/**/test.py Added explicit setting to preserve existing test behavior expecting single-value results

@rschu1ze rschu1ze enabled auto-merge December 10, 2025 18:42
@rschu1ze rschu1ze added this pull request to the merge queue Dec 10, 2025
Merged via the queue into master with commit 32380b8 Dec 10, 2025
126 of 130 checks passed
@rschu1ze rschu1ze deleted the check_query_single_value_result-2 branch December 10, 2025 18:57
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants