Change default of settings check_query_single_value_result#91009
Merged
Change default of settings check_query_single_value_result#91009
check_query_single_value_result#91009Conversation
check_query_single_value_result
Contributor
|
Workflow [PR], commit [f44423f] Summary: ❌
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the default value of the check_query_single_value_result setting from true to false. This means CHECK TABLE will now return detailed per-part results by default instead of a single aggregated value (1 for success, 0 for errors).
Key changes:
- Updated the default setting value in
src/Core/Settings.cpp - Added entry to settings change history in
src/Core/SettingsChangesHistory.cpp - Updated documentation to reflect the new default behavior
- Modified 19 test files to explicitly set
check_query_single_value_result = 1to maintain their existing test behavior
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core/Settings.cpp | Changed default value of check_query_single_value_result from true to false |
| src/Core/SettingsChangesHistory.cpp | Added changelog entry for the setting change |
| docs/en/sql-reference/statements/check-table.md | Updated documentation to reflect new default and improved clarity |
| tests/queries/0_stateless/*.{sh,sql} | Added explicit setting to preserve existing test behavior expecting single-value results |
| tests/integration/**/test.py | Added explicit setting to preserve existing test behavior expecting single-value results |
…gle_value_result-2
…gle_value_result-2
…gle_value_result-2
vitlibar
approved these changes
Dec 8, 2025
…gle_value_result-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-submit of #90150 which was reverted by #90815
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Changed the default of setting
check_query_single_value_resultfromtruetofalse. This causesCHECK TABLEto return detailed per-part results instead of an aggregated result (1 = okay, 0 = errors found). Compared to the previous behavior, this is likely more aligned with what the user wants.