Skip to content

Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree#91151

Merged
Avogar merged 6 commits intoClickHouse:masterfrom
Avogar:summing-agg-mt-merge-json
Dec 1, 2025
Merged

Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree#91151
Avogar merged 6 commits intoClickHouse:masterfrom
Avogar:summing-agg-mt-merge-json

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Nov 28, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree. Previously it could lead to unexpected dynamic paths durign writing to data parts.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 28, 2025

Workflow [PR], commit [d591396]

Summary:

job_name test_name status info comment
Integration tests (amd_asan, db disk, old analyzer, 2/6) failure
test_database_hms/test.py::test_hive_catalog_url_parsing FAIL cidb
test_disabled_mysql_server/test.py::test_disabled_mysql_server FAIL cidb
Integration tests (amd_asan, db disk, old analyzer, 5/6) failure
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[s3-1] FAIL cidb
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[s3-2] FAIL cidb
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[azure-1] FAIL cidb
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[azure-2] FAIL cidb
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[local-1] FAIL cidb
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[local-2] FAIL cidb
Integration tests (amd_binary, 5/5) failure
test_database_delta/test.py::test_embedded_database_and_tables[1] FAIL cidb
test_database_delta/test.py::test_embedded_database_and_tables[0] FAIL cidb
test_database_delta/test.py::test_multiple_schemes_tables FAIL cidb
test_database_delta/test.py::test_complex_table_schema[1] FAIL cidb
test_database_delta/test.py::test_complex_table_schema[0] FAIL cidb
test_database_delta/test.py::test_timestamp_ntz[1] FAIL cidb
test_database_delta/test.py::test_timestamp_ntz[0] FAIL cidb
test_database_delta/test.py::test_no_permission_and_list_tables FAIL cidb
test_database_delta/test.py::test_view_with_void[1] FAIL cidb
test_database_delta/test.py::test_view_with_void[0] FAIL cidb
Integration tests (amd_tsan, 2/6) failure
test_database_hms/test.py::test_hive_catalog_url_parsing FAIL cidb
test_backup_restore_on_cluster/test_different_versions.py::test_different_versions FAIL cidb
test_disabled_mysql_server/test.py::test_disabled_mysql_server FAIL cidb
Integration tests (amd_tsan, 5/6) failure
test_database_delta/test.py::test_embedded_database_and_tables[1] FAIL cidb
test_database_delta/test.py::test_embedded_database_and_tables[0] FAIL cidb
test_database_delta/test.py::test_multiple_schemes_tables FAIL cidb
test_database_delta/test.py::test_complex_table_schema[1] FAIL cidb
test_database_delta/test.py::test_complex_table_schema[0] FAIL cidb
test_database_delta/test.py::test_timestamp_ntz[1] FAIL cidb
test_database_delta/test.py::test_timestamp_ntz[0] FAIL cidb
test_database_delta/test.py::test_no_permission_and_list_tables FAIL cidb
test_database_delta/test.py::test_view_with_void[1] FAIL cidb
test_database_delta/test.py::test_view_with_void[0] FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb
BuzzHouse (amd_msan) failure
Unknown error FAIL cidb

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Nov 28, 2025
@novikd novikd self-assigned this Dec 1, 2025
@Avogar Avogar requested a review from novikd December 1, 2025 12:54
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Dec 1, 2025

Integration tests are broken and failes with timeouts right now

@Avogar Avogar added this pull request to the merge queue Dec 1, 2025
@Avogar Avogar removed this pull request from the merge queue due to a manual request Dec 1, 2025
@Avogar Avogar added this pull request to the merge queue Dec 1, 2025
Merged via the queue into ClickHouse:master with commit 44792fd Dec 1, 2025
240 of 256 checks passed
@Avogar Avogar deleted the summing-agg-mt-merge-json branch December 1, 2025 19:51
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-synced-to-cloud The PR is synced to the cloud repo pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Dec 1, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Dec 1, 2025
Cherry pick #91151 to 25.3: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
robot-clickhouse added a commit that referenced this pull request Dec 1, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Dec 1, 2025
Cherry pick #91151 to 25.8: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
robot-clickhouse added a commit that referenced this pull request Dec 1, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Dec 1, 2025
Cherry pick #91151 to 25.9: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
robot-clickhouse added a commit that referenced this pull request Dec 1, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Dec 1, 2025
Cherry pick #91151 to 25.10: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
robot-clickhouse added a commit that referenced this pull request Dec 1, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Dec 1, 2025
Cherry pick #91151 to 25.11: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
robot-clickhouse added a commit that referenced this pull request Dec 1, 2025
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 1, 2025
clickhouse-gh bot added a commit that referenced this pull request Dec 1, 2025
Backport #91151 to 25.10: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
clickhouse-gh bot added a commit that referenced this pull request Dec 1, 2025
Backport #91151 to 25.11: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
clickhouse-gh bot added a commit that referenced this pull request Dec 1, 2025
Backport #91151 to 25.8: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
clickhouse-gh bot added a commit that referenced this pull request Dec 1, 2025
Backport #91151 to 25.9: Fix merging JSON columns in Summing/Aggregating/Coalescing MergeTree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants