Skip to content

Add a hotkey for commenting out the current line or lines on the /play page#91160

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
OpenGLShaders:sk/add-comment-keyboard-shortcut
Dec 13, 2025
Merged

Add a hotkey for commenting out the current line or lines on the /play page#91160
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
OpenGLShaders:sk/add-comment-keyboard-shortcut

Conversation

@OpenGLShaders
Copy link
Copy Markdown
Contributor

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

  • You can now quickly comment or uncomment your currently selected lines in the Web UI query editor using Ctrl+/ (or Cmd+/ on Mac), making it easier to temporarily disable parts of your query while testing.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 29, 2025

CLA assistant check
All committers have signed the CLA.

@Fgrtue Fgrtue added the can be tested Allows running workflows for external contributors label Dec 4, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 4, 2025

Workflow [PR], commit [2cac495]

Summary:

job_name test_name status info comment
Integration tests (amd_asan, db disk, old analyzer, 1/6) failure
test_filesystem_cache/test.py::test_caches_with_the_same_configuration[node] FAIL cidb
AST fuzzer (arm_asan) failure
Logical error: 'Invalid number of rows in Chunk Nullable(size = 0, Int32(size = 0), UInt8(size = 0)) UInt16(size = 2) UInt8(size = 2) UInt32(size = 2) Int8(size = 2) Int16(size = 2) Int32(size = 2) LowCardinality(size = 2, UInt8(size = 2), Unique(size = 3, Float32(size = 3))) Float64(size = 2) Decimal32(size = 2) Decimal64(size = 2) column Nullable(Int32) at position 0: expected 2, got 0' FAIL cidb
AST fuzzer (amd_tsan) failure
Logical error: 'col.name == prewhere_info->prewhere_column_name' FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb
Performance Comparison (amd_release, master_head, 4/6) failure
Check Results failure

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Dec 4, 2025
@OpenGLShaders
Copy link
Copy Markdown
Contributor Author

@Fgrtue thanks for moving this to the test stage - anything I need to do to get the test failures above resolved? They seem unrelated to my change (from what I can tell at least...)

@Fgrtue Fgrtue requested a review from Copilot December 7, 2025 15:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds keyboard shortcut support for commenting and uncommenting code in the Web UI query editor. Users can now press Ctrl+/ (or Cmd+/ on Mac) to toggle SQL comments on selected lines.

Key Changes:

  • Implements a new keyboard event handler for Ctrl+/ or Cmd+/ that comments/uncomments the currently selected line(s)
  • Uses SQL comment syntax (--) with intelligent handling of already-commented lines
  • Preserves user selection after the operation for easy workflow

@Fgrtue
Copy link
Copy Markdown
Contributor

Fgrtue commented Dec 7, 2025

Hi @OpenGLShaders! Thank you for your contribution.
Yes, the failing tests seem to be unrelated.
Next, please wait until the changed are reviewed.

@alexey-milovidov alexey-milovidov self-assigned this Dec 13, 2025
@alexey-milovidov alexey-milovidov merged commit 0ef4a86 into ClickHouse:master Dec 13, 2025
242 of 256 checks passed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants