Skip to content

Disable parallel inserts if any sink in chain do not support it#91449

Merged
GrigoryPervakov merged 1 commit intomasterfrom
pervakovg/matview-to-no-parallel-inserts
Dec 9, 2025
Merged

Disable parallel inserts if any sink in chain do not support it#91449
GrigoryPervakov merged 1 commit intomasterfrom
pervakovg/matview-to-no-parallel-inserts

Conversation

@GrigoryPervakov
Copy link
Copy Markdown
Member

@GrigoryPervakov GrigoryPervakov commented Dec 3, 2025

Closes: #79419

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixed parallel writes triggered by MaterializedView inserts into storages that do not support them.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 3, 2025

Workflow [PR], commit [9068c5f]

Summary:

job_name test_name status info comment
Stateless tests (arm_asan, targeted) failure
01459_manual_write_to_replicas_quorum_detach_attach FAIL cidb
Integration tests (amd_asan, db disk, old analyzer, 2/6) failure
test_storage_s3_queue/test_5.py::test_failed_startup FAIL cidb
Integration tests (amd_binary, 2/5) failure
test_storage_s3_queue/test_5.py::test_failed_startup FAIL cidb
Integration tests (amd_tsan, 1/6) failure
test_storage_nats/test_nats_jet_stream.py::test_nats_overloaded_insert FAIL cidb
Integration tests (amd_tsan, 2/6) failure
test_storage_s3_queue/test_0.py::test_streaming_to_many_views[ordered] FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 2508-11b5) FAIL cidb
BuzzHouse (amd_ubsan) failure
Logical error: 'Node CAST((CAST('36893488147419103290', 'UInt256'), CAST('21', 'UInt256'), NULL, randomStringUTF8(423)), 'Int32') AS a0 with duplicate alias does not exist in alias table. In scope (SELECT _CAST(1, 'UInt64') FROM (SELECT '2299-12-31' AS a4 FROM system.one) LIMIT _CAST(1, 'UInt64'))' (STID: 2508-11b5) FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Dec 3, 2025
@GrigoryPervakov GrigoryPervakov changed the title Disable parallel inserts if any sinks do not support it Disable parallel inserts if any sink do not support it Dec 3, 2025
@GrigoryPervakov GrigoryPervakov force-pushed the pervakovg/matview-to-no-parallel-inserts branch from 5b7bc44 to 2c46327 Compare December 4, 2025 13:26
@GrigoryPervakov GrigoryPervakov force-pushed the pervakovg/matview-to-no-parallel-inserts branch from 2c46327 to 9068c5f Compare December 4, 2025 14:38
@GrigoryPervakov GrigoryPervakov changed the title Disable parallel inserts if any sink do not support it Disable parallel inserts if any sink in chain do not support it Dec 5, 2025
@GrigoryPervakov GrigoryPervakov marked this pull request as ready for review December 5, 2025 13:19
@Avogar Avogar self-assigned this Dec 8, 2025
@GrigoryPervakov
Copy link
Copy Markdown
Member Author

01459_manual_write_to_replicas_quorum_detach_attach is flaky
test_storage_s3_queue/test_storage_nats are known to be flaky and have retry_ok

@GrigoryPervakov GrigoryPervakov added this pull request to the merge queue Dec 9, 2025
Merged via the queue into master with commit e5b7337 Dec 9, 2025
122 of 130 checks passed
@GrigoryPervakov GrigoryPervakov deleted the pervakovg/matview-to-no-parallel-inserts branch December 9, 2025 15:58
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel with Log engine table insert stuck

3 participants