Skip to content

Print more diagnostics in AST formatting check#91519

Merged
tavplubix merged 2 commits intomasterfrom
better_ast_check
Dec 5, 2025
Merged

Print more diagnostics in AST formatting check#91519
tavplubix merged 2 commits intomasterfrom
better_ast_check

Conversation

@tavplubix
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Try to find the problimatic AST part so it will be easier to find similar failures in the CI

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Dec 4, 2025

Workflow [PR], commit [b938516]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
01287_max_execution_speed FAIL cidb, issue
Stateless tests (amd_msan, parallel) failure
00411_long_accurate_number_comparison_int2 FAIL cidb
02992_all_columns_should_have_comment FAIL cidb
00816_long_concurrent_alter_column FAIL cidb, issue
Integration tests (amd_asan, db disk, old analyzer, 3/6) failure
test_concurrent_ttl_merges/test.py::test_limited_ttl_merges_in_empty_pool_replicated FAIL cidb
test_plain_rewritable_backward_compatibility/test.py::test_backward_compatibility[table_disk = 1, disk = 's3_plain_rewritable'-1] FAIL cidb
test_plain_rewritable_backward_compatibility/test.py::test_backward_compatibility_readonly_tables FAIL cidb
test_concurrent_ttl_merges/test.py::test_limited_ttl_merges_two_replicas FAIL cidb
Integration tests (amd_tsan, 1/6) failure
test_storage_nats/test_nats_jet_stream.py::test_nats_overloaded_insert FAIL cidb, issue
AST fuzzer (amd_debug) failure
Logical error: 'Bad cast from type DB::ColumnConst to DB::ColumnArray' (STID: 2508-11b5) FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting in Function_arrayElement: the query: (STID: 2508-11b5) FAIL cidb

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 4, 2025
Comment thread src/Interpreters/executeQuery.cpp Outdated
@maxknv maxknv self-assigned this Dec 4, 2025
@tavplubix
Copy link
Copy Markdown
Member Author

BuzzHouse (amd_debug) - https://s3.amazonaws.com/clickhouse-test-reports/PRs/91519/b938516de856fa9e1c3a0ed5faafc5684935c650//buzzhouse_amd_debug/fatal.log

2025.12.04 18:04:11.423097 [ 633 ] {82c08239-a854-4d58-963e-638e574f40ed} <Fatal> executeQuery: Suspicious part of the AST: ExpressionList: SELECT -(-1.388846659701798e37 AS a0)[c0] FROM d3.t11 AS t0d0 RIGHT JOIN d2.t17 AS t1d0 ON NOT (t0d0.`c0.null` < t1d0.`c1.null`)
2025.12.04 18:04:11.423130 [ 633 ] {82c08239-a854-4d58-963e-638e574f40ed} <Fatal> executeQuery: Suspicious part of the AST: SelectQuery: SELECT -(-1.388846659701798e37 AS a0)[c0] FROM d3.t11 AS t0d0 RIGHT JOIN d2.t17 AS t1d0 ON NOT (t0d0.`c0.null` < t1d0.`c1.null`)
2025.12.04 18:04:11.423139 [ 633 ] {82c08239-a854-4d58-963e-638e574f40ed} <Fatal> executeQuery: Suspicious part of the AST: ExpressionList: -(-1.388846659701798e37 AS a0)[c0]
2025.12.04 18:04:11.423146 [ 633 ] {82c08239-a854-4d58-963e-638e574f40ed} <Fatal> executeQuery: Suspicious part of the AST: Function_arrayElement: -(-1.388846659701798e37 AS a0)[c0]
2025.12.04 18:04:11.423152 [ 633 ] {82c08239-a854-4d58-963e-638e574f40ed} <Fatal> executeQuery: Cannot find formatted child in the formatted query: -(-1.388846659701798e37 AS a0), c0
2025.12.04 18:04:11.423182 [ 633 ] {82c08239-a854-4d58-963e-638e574f40ed} <Fatal> : Logical error: 'Inconsistent AST formatting in Function_arrayElement: the query:

@tavplubix tavplubix added this pull request to the merge queue Dec 5, 2025
Merged via the queue into master with commit 09ac399 Dec 5, 2025
123 of 130 checks passed
@tavplubix tavplubix deleted the better_ast_check branch December 5, 2025 16:17
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants