Adding tokenizer factory to reduce code duplication#91529
Merged
Conversation
Contributor
|
Workflow [PR], commit [c5de17c] Summary: ❌
|
ae9d4a7 to
2408fe4
Compare
2408fe4 to
ffffc73
Compare
…g-add-tokenizer-factory
rschu1ze
approved these changes
Dec 8, 2025
Member
|
Stateless tests (arm_asan, targeted)
Integration tests (amd_tsan, 2/6)
BuzzHouse (amd_debug)
|
This was referenced Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding tokenizer factory to reduce code duplication in several places. A side effect of this change is that the 3 places where we use tokenizers (regular text index, bloom filter text index, and tokens function) now all use the same defaults and params checks. Before, the bloom filter text index allowed any value for ngram_length, while the other two allowed only values between 2 and 8. I decided to make the allowed values be between 1 and 8 for all, but this could be changed if needed.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Ngrams tokenizer can now be built with ngram_length = 1.
Documentation entry for user-facing changes