Skip to content

Fix logical error caused by Nothing type in caseWithExpression function #92351

Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
nihalzp:fix-case-with-expression
Dec 17, 2025
Merged

Fix logical error caused by Nothing type in caseWithExpression function #92351
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
nihalzp:fix-case-with-expression

Conversation

@nihalzp
Copy link
Copy Markdown
Member

@nihalzp nihalzp commented Dec 17, 2025

The following query has logical error:

SELECT caseWithExpression(1, assumeNotNull(materialize(NULL)), 1, 1);

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix logical error caused by using Nothing type in caseWithExpression function arguments . Closes #85354.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 17, 2025 •
edited
Loading

Workflow [PR], commit [f3a8767]

Summary: ⏳

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Dec 17, 2025
alexey-milovidov
alexey-milovidov reviewed Dec 17, 2025
View reviewed changes
tests/queries/0_stateless/03390_non_constant_case.sql
); -- { serverError ILLEGAL_COLUMN }
); -- { serverError ILLEGAL_TYPE_OF_ARGUMENT }

SELECT caseWithExpression('C', 'A', true, 'B', false); -- { serverError BAD_ARGUMENTS }
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we prefer adding new tests rather than modifying existing tests.

@alexey-milovidov alexey-milovidov self-assigned this Dec 17, 2025
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Dec 17, 2025
Merged via the queue into ClickHouse:master with commit 1c42187 Dec 17, 2025
250 of 256 checks passed
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-synced-to-cloud The PR is synced to the cloud repo pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Dec 17, 2025
This was referenced Dec 17, 2025
Closed
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 17, 2025
@robot-ch-test-poll3
Merge pull request #92433 from ClickHouse/cherrypick/25.8/92351
22030da 
Cherry pick #92351 to 25.8: Fix logical error caused by `Nothing` type in `caseWithExpression` function
robot-clickhouse added a commit that referenced this pull request Dec 17, 2025
@robot-clickhouse
Backport #92351 to 25.8: Fix logical error caused by Nothing type i…
67636fb 
…n `caseWithExpression` function
This was referenced Dec 17, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 17, 2025
@robot-ch-test-poll3
Merge pull request #92435 from ClickHouse/cherrypick/25.9/92351
662523f 
Cherry pick #92351 to 25.9: Fix logical error caused by `Nothing` type in `caseWithExpression` function
robot-clickhouse added a commit that referenced this pull request Dec 17, 2025
@robot-clickhouse
Backport #92351 to 25.9: Fix logical error caused by Nothing type i…
1252cd9 
…n `caseWithExpression` function
This was referenced Dec 17, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 17, 2025
@robot-ch-test-poll3
Merge pull request #92437 from ClickHouse/cherrypick/25.10/92351
e55fa38 
Cherry pick #92351 to 25.10: Fix logical error caused by `Nothing` type in `caseWithExpression` function
robot-clickhouse added a commit that referenced this pull request Dec 17, 2025
@robot-clickhouse
Backport #92351 to 25.10: Fix logical error caused by Nothing type …
b45871b 
…in `caseWithExpression` function
This was referenced Dec 17, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 17, 2025
@robot-ch-test-poll3
Merge pull request #92439 from ClickHouse/cherrypick/25.11/92351
434c34f 
Cherry pick #92351 to 25.11: Fix logical error caused by `Nothing` type in `caseWithExpression` function
robot-clickhouse added a commit that referenced this pull request Dec 17, 2025
@robot-clickhouse
Backport #92351 to 25.11: Fix logical error caused by Nothing type …
65c3fa7 
…in `caseWithExpression` function
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Dec 17, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Dec 17, 2025
@clickhouse-gh
Merge pull request #92440 from ClickHouse/backport/25.11/92351
2199c84 
Backport #92351 to 25.11: Fix logical error caused by `Nothing` type in `caseWithExpression` function
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 18, 2025
clickhouse-gh bot added a commit that referenced this pull request Dec 18, 2025
@clickhouse-gh
Merge pull request #92438 from ClickHouse/backport/25.10/92351
43fb444 
Backport #92351 to 25.10: Fix logical error caused by `Nothing` type in `caseWithExpression` function
clickhouse-gh bot added a commit that referenced this pull request Dec 18, 2025
@clickhouse-gh
Merge pull request #92436 from ClickHouse/backport/25.9/92351
c6f5273 
Backport #92351 to 25.9: Fix logical error caused by `Nothing` type in `caseWithExpression` function
clickhouse-gh bot added a commit that referenced this pull request Dec 18, 2025
@clickhouse-gh
Merge pull request #92434 from ClickHouse/backport/25.8/92351
4085934 
Backport #92351 to 25.8: Fix logical error caused by `Nothing` type in `caseWithExpression` function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

3 participants

@nihalzp @alexey-milovidov @robot-ch-test-poll1