Fix flaky dynamically_resize_filesystem_cache#93164
Conversation
clickhouse-gh
Bot
added
the
pr-not-for-changelog
| config_path=${CLICKHOUSE_CONFIG_DIR}/config.d/storage_conf.xml | ||
|
|
||
| new_max_size=$($CLICKHOUSE_CLIENT --query "SELECT divide(max_size, 2) FROM system.filesystem_cache_settings WHERE cache_name = '$disk_name'") | ||
| new_max_size=$($CLICKHOUSE_CLIENT --query "SELECT max_size * 0.8 FROM system.filesystem_cache_settings WHERE cache_name = '$disk_name'") |
There was a problem hiding this comment.
The same cache is reused by other tests, which did not let this test evict enough for the resize, so I reduced the eviction numbers
There was a problem hiding this comment.
Since it's already an .sh test, why can't we create a table with a separate cache folder? Similar to how it is done here: #93036
There was a problem hiding this comment.
Just to catch bugs given the concurrent execution with reads, though there is now another test named dynamically_resize_filesystem_cache_3.sh, which checks it, so I'll indeed make a separate cache for dynamically_resize_filesystem_cache_2.sh
| <clickhouse> | ||
| <logger> | ||
| <level>trace</level> | ||
| <level>test</level> |
There was a problem hiding this comment.
Do we really want this? AFAIR it is slow even for CI
Also this is logger_trace.xml and there is logger_test.xml
There was a problem hiding this comment.
This was temporary, to see why test fails
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
|
@kssenii, it is still flaky. |
5 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes