Skip to content

Query condition cache not for tables without UUIDs#93423

Merged
rschu1ze merged 4 commits intoClickHouse:masterfrom
shankar-iyer:fix_qcc_memory_db_engine
Jan 6, 2026
Merged

Query condition cache not for tables without UUIDs#93423
rschu1ze merged 4 commits intoClickHouse:masterfrom
shankar-iyer:fix_qcc_memory_db_engine

Conversation

@shankar-iyer
Copy link
Copy Markdown
Member

@shankar-iyer shankar-iyer commented Jan 5, 2026

Resolves #92863

Query condition cache by design only supports tables in Atomic and Replicated database engines. Added check in the code to not read/write the cache if a table's part does not have a valid UUID (e.g Memory database engine).

Changelog category (leave one):

  • Not for changelog

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Jan 5, 2026

Workflow [PR], commit [9f1ac83]

Summary:

job_name test_name status info comment
Integration tests (amd_asan, db disk, old analyzer, 2/6) failure
test_backup_restore_on_cluster/test_concurrency.py::test_create_or_drop_tables_during_backup[Replicated-ReplicatedMergeTree] FAIL cidb, issue ISSUE EXISTS
test_backup_restore_on_cluster/test_concurrency.py::test_create_or_drop_tables_during_backup[Memory-MergeTree] FAIL cidb, issue ISSUE EXISTS
test_backup_restore_on_cluster/test_concurrency.py::test_create_or_drop_tables_during_backup[Lazy-Log] FAIL cidb, issue ISSUE EXISTS
test_backup_restore_on_cluster/test_concurrency.py::test_kill_mutation_during_backup FAIL cidb, issue ISSUE EXISTS
Integration tests (amd_binary, 2/5) failure
test_backup_restore_new/test.py::test_skip_rmv_backup FAIL cidb IGNORED
test_backup_restore_on_cluster/test_concurrency.py::test_create_or_drop_tables_during_backup[Replicated-ReplicatedMergeTree] FAIL cidb, issue ISSUE EXISTS
test_backup_restore_on_cluster/test_concurrency.py::test_create_or_drop_tables_during_backup[Memory-MergeTree] FAIL cidb, issue ISSUE EXISTS
test_backup_restore_on_cluster/test_concurrency.py::test_create_or_drop_tables_during_backup[Lazy-Log] FAIL cidb, issue ISSUE EXISTS
test_backup_restore_on_cluster/test_concurrency.py::test_kill_mutation_during_backup FAIL cidb, issue ISSUE EXISTS
Integration tests (arm_binary, distributed plan, 4/4) failure
test_userspace_page_cache/test.py::test_size_adjustment FAIL cidb, issue ISSUE EXISTS
Integration tests (amd_tsan, 2/6) failure
test_distributed_respect_user_timeouts/test.py::test_reconnect[configs-ready_to_wait-node1-distributed] FAIL cidb, issue ISSUE CREATED
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL cidb, issue ISSUE EXISTS
BuzzHouse (amd_ubsan) failure
Logical error: No information about file A in StorageLog (STID: 4755-6af9) FAIL cidb IGNORED

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 5, 2026
@shankar-iyer shankar-iyer requested a review from rschu1ze January 6, 2026 04:51
@shankar-iyer
Copy link
Copy Markdown
Member Author

Clean CI run at [bf58342]

@rschu1ze rschu1ze self-assigned this Jan 6, 2026
@rschu1ze rschu1ze added this pull request to the merge queue Jan 6, 2026
Merged via the queue into ClickHouse:master with commit f92d721 Jan 6, 2026
124 of 131 checks passed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression with query condition cache on Memory engine in 25.10

3 participants