Fix support for Prometheus Remote Read protocol#93791
Merged
vitlibar merged 2 commits intoClickHouse:masterfrom Jan 12, 2026
Merged
Fix support for Prometheus Remote Read protocol#93791vitlibar merged 2 commits intoClickHouse:masterfrom
vitlibar merged 2 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [33b3990] Summary: ❌
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes support for the Prometheus Remote Read protocol by addressing a buffer management issue in protobuf serialization and enhancing test coverage with a large dataset test.
Key changes:
- Added
nextIfAtEnd()call inProtobufZeroCopyOutputStreamFromWriteBuffer::Next()to ensure buffer availability before writing - Introduced comprehensive test for Remote Read protocol with 75,000 data points
- Refactored test setup to populate data once during cluster initialization rather than per-test
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/IO/Protobuf/ProtobufZeroCopyOutputStreamFromWriteBuffer.cpp | Fixed buffer handling by ensuring next buffer chunk is available before writing |
| tests/integration/test_prometheus_protocols/test_write_read.py | Added large dataset test, refactored data population to fixture, and renamed wait function for clarity |
nikitamikhaylov
approved these changes
Jan 9, 2026
Member
Author
Merged
via the queue into
ClickHouse:master
with commit Jan 12, 2026
0123cf3
128 of 132 checks passed
This was referenced Jan 12, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jan 12, 2026
Cherry pick #93791 to 25.8: Fix support for Prometheus Remote Read protocol
robot-clickhouse
added a commit
that referenced
this pull request
Jan 12, 2026
This was referenced Jan 12, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jan 12, 2026
Cherry pick #93791 to 25.10: Fix support for Prometheus Remote Read protocol
robot-clickhouse
added a commit
that referenced
this pull request
Jan 12, 2026
This was referenced Jan 12, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jan 12, 2026
Cherry pick #93791 to 25.11: Fix support for Prometheus Remote Read protocol
robot-clickhouse
added a commit
that referenced
this pull request
Jan 12, 2026
This was referenced Jan 12, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jan 12, 2026
Cherry pick #93791 to 25.12: Fix support for Prometheus Remote Read protocol
robot-clickhouse
added a commit
that referenced
this pull request
Jan 12, 2026
nikitamikhaylov
added a commit
that referenced
this pull request
Jan 12, 2026
Backport #93791 to 25.12: Fix support for Prometheus Remote Read protocol
nikitamikhaylov
added a commit
that referenced
this pull request
Jan 12, 2026
Backport #93791 to 25.11: Fix support for Prometheus Remote Read protocol
nikitamikhaylov
added a commit
that referenced
this pull request
Jan 12, 2026
Backport #93791 to 25.10: Fix support for Prometheus Remote Read protocol
nikitamikhaylov
added a commit
that referenced
this pull request
Jan 12, 2026
Backport #93791 to 25.8: Fix support for Prometheus Remote Read protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix support for Prometheus Remote Read protocol