Skip to content

Facilitate devirtualization with additional linker option#94737

Merged
alexey-milovidov merged 4 commits intomasterfrom
try_improve_devirt
Jan 26, 2026
Merged

Facilitate devirtualization with additional linker option#94737
alexey-milovidov merged 4 commits intomasterfrom
try_improve_devirt

Conversation

@nickitat
Copy link
Member

@nickitat nickitat commented Jan 21, 2026

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Devirtualization is improved with additional linker options.

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Jan 21, 2026

Workflow [PR], commit [24594ad]

Summary:

job_name test_name status info comment
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL cidb, issue
BuzzHouse (arm_asan) failure
Logical error: 'Pipeline stuck. Current state: (STID: 3833-4127) FAIL cidb
Stateless tests (arm_asan, targeted) error

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 21, 2026
@nickitat nickitat added pr-performance Pull request with some performance improvements ci-performance performance only and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jan 21, 2026
@nickitat
Copy link
Member Author

I haven't checked the generated code, but I ran CI twice to filter out noise. The following changes persist:

amd:
Screenshot 2026-01-21 at 22 31 55
Screenshot 2026-01-21 at 22 33 26
Screenshot 2026-01-21 at 22 34 38

arm:
Screenshot 2026-01-21 at 22 37 54
Screenshot 2026-01-21 at 22 39 24
Screenshot 2026-01-21 at 22 40 55
Screenshot 2026-01-21 at 22 42 23

@nickitat
Copy link
Member Author

Interestingly enough, one degradation also persists:

Screenshot 2026-01-21 at 22 49 13

Need to check the code and insert a 🩼 somewhere

@nickitat nickitat removed the ci-performance performance only label Jan 21, 2026
@nickitat nickitat changed the title Test if this linker option improves anything Facilitate devirtualization with additional linker option Jan 21, 2026
@alexey-milovidov alexey-milovidov self-assigned this Jan 21, 2026
@nickitat
Copy link
Member Author

Interestingly enough, one degradation also persists:

Screenshot 2026-01-21 at 22 49 13 Need to check the code and insert a 🩼 somewhere

Maybe it was a false positive, too, since in the last run for both platforms, this test looks fine: amd, arm

@nickitat nickitat marked this pull request as ready for review January 26, 2026 18:19
@nickitat nickitat enabled auto-merge January 26, 2026 18:20
@alexey-milovidov alexey-milovidov merged commit 8eccaa2 into master Jan 26, 2026
126 of 132 checks passed
@alexey-milovidov alexey-milovidov deleted the try_improve_devirt branch January 26, 2026 19:28
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-performance Pull request with some performance improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants