Respect max_parts_to_merge_at_once in TTLPartDropMergeSelector#95315
Merged
Respect max_parts_to_merge_at_once in TTLPartDropMergeSelector#95315
Conversation
Contributor
|
Workflow [PR], commit [de0519c] Summary: ❌
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for respecting the max_parts_to_merge_at_once setting in TTL drop part merges, which previously only applied to regular merges but not TTL-based operations.
Changes:
- Modified
TTLPartDropMergeSelectorto accept and enforcemax_parts_to_merge_at_oncelimit - Updated merge selection logic to track and respect part count limits alongside existing memory and row constraints
- Added integration test to verify the limit is properly enforced during TTL drop merges
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Storages/MergeTree/Compaction/MergeSelectors/TTLMergeSelector.h | Added max_parts_to_merge_at_once parameter to constructors and border-finding methods |
| src/Storages/MergeTree/Compaction/MergeSelectors/TTLMergeSelector.cpp | Implemented part count tracking and enforcement in merge range selection logic |
| src/Storages/MergeTree/Compaction/MergeSelectorApplier.cpp | Passed max_parts_to_merge_at_once setting to TTLPartDropMergeSelector constructor |
| src/Interpreters/PartLog.cpp | Updated documentation to include TTLDropMerge as a merge reason |
| tests/integration/test_ttl_replicated/test.py | Added comprehensive test verifying part count limit enforcement in TTL drop merges |
Michicosun
approved these changes
Jan 27, 2026
This was referenced Jan 28, 2026
Closed
Closed
Closed
Closed
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Jan 28, 2026
Cherry pick #95315 to 25.12: Respect max_parts_to_merge_at_once in TTLPartDropMergeSelector
This was referenced Jan 28, 2026
Merged
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Jan 28, 2026
Cherry pick #95315 to 26.1: Respect max_parts_to_merge_at_once in TTLPartDropMergeSelector
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 28, 2026
Backport #95315 to 25.12: Respect max_parts_to_merge_at_once in TTLPartDropMergeSelector
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 28, 2026
Backport #95315 to 26.1: Respect max_parts_to_merge_at_once in TTLPartDropMergeSelector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Respect
max_parts_to_merge_at_oncein TTL drop part merges.Documentation entry for user-facing changes