Support auxiliary keeper for DatabaseReplicated (Resubmit of #91683).#95590
Merged
evillique merged 3 commits intoClickHouse:masterfrom Feb 27, 2026
Merged
Conversation
alexey-milovidov
added
the
can be tested
Contributor
Author
|
PTAL @evillique @tavplubix |
Contributor
|
Workflow [PR], commit [f121f07] Summary: ❌
|
RinChanNOWWW
force-pushed
the
replicated-db-aux-keeper-resubmit
branch
from
8156e95 to
eda3df3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
RinChanNOWWW
force-pushed
the
replicated-db-aux-keeper-resubmit
branch
from
eda3df3 to
56cd027
Compare
Contributor
Author
|
Please assign a reviewer for this PR @evillique @tavplubix @alexey-milovidov |
Member
|
Tests aren't green. |
Contributor
Author
|
The failures may be unrelated. |
RinChanNOWWW
force-pushed
the
replicated-db-aux-keeper-resubmit
branch
from
56cd027 to
1b68e19
Compare
Member
|
Where was the bug that caused LOGICAL_ERROR, and how was it fixed? |
Contributor
Author
According to issue #95539, the bug was not introduced by my PR. And the bug was fixed by PR #95664. |
RinChanNOWWW
force-pushed
the
replicated-db-aux-keeper-resubmit
branch
from
ba99597 to
19d001c
Compare
Member
|
I am sorry, I got distracted and forgot about this PR. Could you please resolve the conflicts? |
Mark getObjectStorage as const. Add docs and tests. Fix. Fix drop replica. Fix getQueryStatus. Fix test. Fix zookeeper usage. Fix codes review. Split the tests.
RinChanNOWWW
force-pushed
the
replicated-db-aux-keeper-resubmit
branch
from
19d001c to
f121f07
Compare
Contributor
Author
Done. |
evillique
approved these changes
Feb 27, 2026
Merged
via the queue into
ClickHouse:master
with commit Feb 27, 2026
43cc85b
146 of 148 checks passed
robot-ch-test-poll3
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already support auxiliary zookeeper for storing metadata of
ReplicatedMergeTreelong time ago. This PR supports auxiliary zookeeper forDatabaseReplicated.Resubmit of #91683.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Support auxiliary zookeeper for
DatabaseReplicated.Documentation entry for user-facing changes