Skip to content

ci: fix old system log tables rotation in upgrade check#95843

Merged
fm4v merged 3 commits intoClickHouse:masterfrom
azat:upgrade-rename
Feb 4, 2026
Merged

ci: fix old system log tables rotation in upgrade check#95843
fm4v merged 3 commits intoClickHouse:masterfrom
azat:upgrade-rename

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Feb 2, 2026

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Upgrade job cannot RENAME old system tables because it mixes S3 and local disk policy:

2026.01.23 00:47:54.383367 [ 1094548 ] {} <Error> void DB::SystemLog<DB::ZooKeeperConnectionLogElement>::flushImpl(const std::vector<LogElement> &, uint64_t) [LogElement = DB::ZooKeeperConnectionLogElement]: Failed to flush system log system.zookeeper_connection_log with 1 entries up to offset 1: Code: 57. DB::Exception: Directory for table data data/system/zookeeper_connection_log/ already exists. (TABLE_ALREADY_EXISTS), Stack trace (when copying this message, always include the lines below):

This was needed because previously clickhouse-local was not able to dump tables from S3 (due to we do not pass config), but now it should work, and we can simply remove it

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Feb 2, 2026

Workflow [PR], commit [edc6c1c]

Summary:

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 2, 2026
@azat azat marked this pull request as ready for review February 3, 2026 16:18
@azat azat changed the title ci: do not ignore errors during flushing system tables in upgrade job ci: fix old system log tables rotation in upgrade check Feb 3, 2026
@azat azat requested a review from fm4v February 4, 2026 11:53
@fm4v fm4v added this pull request to the merge queue Feb 4, 2026
@fm4v fm4v self-assigned this Feb 4, 2026
Merged via the queue into ClickHouse:master with commit 7228266 Feb 4, 2026
131 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants