Conversation
Contributor
2850ae0 to
dc41c45
Compare
When an affected job requires another job by name (not artifact name), treat it as an ordering-only dependency and exclude it from `all_required_artifacts`. This prevents keeping alive jobs that only serve non-artifact-producing dependencies. Example: If Job D (affected) requires Job C (provides nothing), and Job C requires artifacts from Job B, Job B will now be correctly skipped. Also added documentation for `native_jobs.py` explaining the job filtering logic. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1c3a23d to
86f7d6a
Compare
82dbf71 to
e24ef5c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a Praktika CI proof-of-concept for managing AWS-based CI infrastructure (Dedicated Hosts / EC2 / Image Builder / Launch Templates / ASGs) and adds a macOS smoke test job, along with CLI/Docs updates to deploy/shutdown infrastructure via praktika infrastructure.
Changes:
- Add new infrastructure components (DedicatedHost, EC2Instance, IAMInstanceProfile, ImageBuilder, LaunchTemplate, AutoScalingGroup) and integrate them into
CloudInfrastructure. - Extend Praktika CLI with an
infrastructuresubcommand supporting--deploy/--shutdownand--only. - Add macOS smoke test job and wire it into PR workflow dependencies; update workflow log timestamping.
Reviewed changes
Copilot reviewed 32 out of 42 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| ci/workflows/pull_request.py | Adds macOS smoke test job dependency on the Darwin binary artifact. |
| ci/praktika/yaml_generator.py | Changes job log timestamping implementation for generated workflows. |
| ci/praktika/native_jobs.py | Adjusts affected-job filtering logic to distinguish artifact vs job-name requirements. |
| ci/praktika/native_jobs.md | Documents Praktika “native jobs” and job filtering behavior. |
| ci/praktika/infrastructure/native/lambda_slack_worker.py | Tweaks Slack message formatting (removes divider). |
| ci/praktika/infrastructure/native/README.md | Updates infra deployment command docs to new CLI. |
| ci/praktika/infrastructure/launch_template.py | Adds EC2 Launch Template IaC component. |
| ci/praktika/infrastructure/lambda_function.py | Removes lambda config dump helper. |
| ci/praktika/infrastructure/image_builder.py | Adds EC2 Image Builder IaC component. |
| ci/praktika/infrastructure/iam_instance_profile.py | Adds IAM Role + Instance Profile IaC component. |
| ci/praktika/infrastructure/ec2_instance.py | Adds EC2 instance IaC component (create/tag/start/terminate). |
| ci/praktika/infrastructure/dedicated_host.py | Adds Dedicated Host pool IaC component (allocate/release). |
| ci/praktika/infrastructure/cloud.py | Expands CloudInfrastructure to orchestrate multiple IaC components with --only support. |
| ci/praktika/infrastructure/autoscaling_group.py | Adds Auto Scaling Group IaC component. |
| ci/praktika/infrastructure/README.md | Updates infra module docs, adds examples for new components and --only/--shutdown. |
| ci/praktika/html_page_development.md | Updates HTML upload invocation to the new infrastructure CLI. |
| ci/praktika/main.py | Replaces old deploy/html subcommands with unified infrastructure command. |
| ci/jobs/smoke_test.py | Adds macOS smoke test script that runs a basic server/query validation. |
| ci/jobs/fast_test.py | Adjusts temp dir path and adds a Darwin-specific execution path. |
| ci/infra/scripts/user_data_macos.txt | Adds macOS runner bootstrap user-data script (brew, packages, runner install, cloud-init). |
| ci/infra/cloud.py | Adds PoC infra config for macOS hosts/instances and IAM instance profile. |
| ci/defs/job_configs.py | Adds macOS smoke test job config; factors fast-test digest config. |
| ci/defs/defs.py | Adds macOS self-hosted runner labels and macOS smoke test job name. |
| .github/workflows/vectorsearchstress.yml | Updates log timestamping pipeline for Praktika-run steps. |
| .github/workflows/release_branches.yml | Updates log timestamping pipeline for Praktika-run steps. |
| .github/workflows/nightly_statistics.yml | Updates log timestamping pipeline for Praktika-run steps. |
| .github/workflows/nightly_jepsen.yml | Updates log timestamping pipeline for Praktika-run steps. |
| .github/workflows/nightly_fuzzers.yml | Updates log timestamping pipeline for Praktika-run steps. |
| .github/workflows/nightly_coverage.yml | Updates log timestamping pipeline for Praktika-run steps. |
| .github/workflows/merge_queue.yml | Updates log timestamping pipeline for Praktika-run steps. |
| .github/workflows/hourly.yml | Updates log timestamping pipeline for Praktika-run steps. |
| .github/workflows/backport_branches.yml | Updates log timestamping pipeline for Praktika-run steps. |
8db9122 to
938a57a
Compare
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
This PR introduces Infrastructure as Code (IaaS) support in Praktika as a proof of concept, enabling automated deployment and configuration of CI infrastructure components.
Key changes:
PoC for IaaS support in Praktika: Configure and deploy cloud CI infrastructure components (dedicated hosts, EC2 instances, ASGs, IAMProfile) via Python Praktika's objects
Improved Praktika CLI interface: Deploy infrastructure with
praktika infrastructure --deploy --only COMPONENTSInfrastructure configuration documentation: Added README about infrastructure configuration via Praktika
MacOS infrastructure setup: Basic configuration for MacOS metal hosts and EC2 instances for macOS tests
Smoke test: Added MacOS functional tests job to validate the infrastructure (deployed metal host, and ec2 ci runner)
This lays the groundwork for managing CI infrastructure declaratively through Praktika.