Skip test_jemalloc_percpu_arena when CPU online override is ineffective#96300
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 8, 2026
Merged
Skip test_jemalloc_percpu_arena when CPU online override is ineffective#96300alexey-milovidov merged 1 commit intomasterfrom
test_jemalloc_percpu_arena when CPU online override is ineffective#96300alexey-milovidov merged 1 commit intomasterfrom
Conversation
The test bind-mounts a fake /sys/devices/system/cpu/online to simulate having fewer online CPUs than configured. However, `sysconf(_SC_NPROCESSORS_ONLN)` does not always read from that file - glibc can use `sched_getaffinity` instead, especially on newer kernels or ARM. When the override doesn't take effect, the test fails with `assert online_cpus == 1` getting the real CPU count. Skip instead of failing, since the test's precondition cannot be guaranteed on all systems. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [1128a20] Summary: ❌
|
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test bind-mounts a fake /sys/devices/system/cpu/online to simulate having fewer online CPUs than configured. However,
sysconf(_SC_NPROCESSORS_ONLN)does not always read from that file - glibc can usesched_getaffinityinstead, especially on newer kernels or ARM. When the override doesn't take effect, the test fails withassert online_cpus == 1getting the real CPU count.Skip instead of failing, since the test's precondition cannot be guaranteed on all systems.
Changelog category (leave one):