Fix UBSan: calling .front() on empty vector in tryRerangeRightTableData#96321
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 8, 2026
Merged
Fix UBSan: calling .front() on empty vector in tryRerangeRightTableData#96321alexey-milovidov merged 1 commit intomasterfrom
.front() on empty vector in tryRerangeRightTableData#96321alexey-milovidov merged 1 commit intomasterfrom
Conversation
…eData` The guard condition checked `data->maps.size() > 1` which correctly returned early for multiple disjuncts but allowed size 0 (empty maps, e.g. from CROSS JOIN) to fall through, causing undefined behavior when calling `.front()` on the empty vector. Change the condition to `data->maps.size() != 1` so we only proceed when there is exactly one map. Closes #95518 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [8e12c4b] Summary: ❌
|
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard condition checked
data->maps.size() > 1which correctly returned early for multiple disjuncts but allowed size 0 (empty maps, e.g. from CROSS JOIN) to fall through, causing undefined behavior when calling.front()on the empty vector.Change the condition to
data->maps.size() != 1so we only proceed when there is exactly one map.Closes #95518
Changelog category (leave one):