do not miss original exception in std::iostreams

[CheSema]

We have tons of classes in POCO which use multiple inheritance like this

class Net_API HTTPChunkedOutputStream : public HTTPChunkedIOS, public std::ostream
class Net_API HTTPChunkedInputStream : public HTTPChunkedIOS, public std::istream

Here HTTPChunkedIOS and HTTPChunkedIOS do poco_ios_init(&_buf); in its c-tors. which is

#if defined(POCO_IOS_INIT_HACK)
#    define poco_ios_init(buf)
#else
#    define poco_ios_init(buf) do {                         \
    init(buf);                                              \
    this->exceptions(std::ios::failbit | std::ios::badbit); \
} while (0)
#endif

the main thing here is this->exceptions(std::ios::failbit | std::ios::badbit);

BUT the second parent std::ostream/std::istream does only this->init(__sb); and by this it rewrites __exceptions_ = goodbit;
So all the efforts with poco_ios_init was in vain. Thanks @Diskein, he quickly noticed that override.

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

set this->exceptions(std::ios::badbit); for the std's streams inside Poco.

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

[clickhouse-gh]

Workflow [PR], commit [4fd256a]

Summary: ❌

job_name	test_name	status	info	comment
Finish Workflow		failure
	python3 ./ci/jobs/scripts/workflow_hooks/pr_body_check.py	failure

[alexey-milovidov]

This is golden! Thanks, @Diskein!

[serxa]

Are you okay if I backport this fix?