Fix flaky test_filesystem_split_cache boundary condition#96508
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 10, 2026
Merged
Fix flaky test_filesystem_split_cache boundary condition#96508alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
The `test_split_cache_restart` test failed with `assert 0.5 < 0.5` because cache went from 18 to 9 entries after restart (exactly 50% change). This happens when `OPTIMIZE TABLE` merges parts and the old parts' cache entries get cleaned up on restart. Changed `< 0.5` to `<= 0.5` in both tolerance checks to include the boundary. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=96480&sha=eb28c4c0578c9e986eaca6dab5b2e7293bd0ae9e&name_0=PR&name_1=Integration%20tests%20%28amd_asan%2C%20db%20disk%2C%20old%20analyzer%2C%206%2F6%29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
kssenii
approved these changes
Feb 10, 2026
robot-ch-test-poll3
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_split_cache_restartfailing withassert 0.5 < 0.5— cache went from 18 to 9 entries after restart, hitting the strict boundary of the tolerance checkOPTIMIZE TABLEmerges parts, old parts' cache entries get cleaned up on restart, causing exactly 50% of entries to disappear< 0.5to<= 0.5in both tolerance assertions to accept the boundary caseTest plan
assert 0.5 < 0.5https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=96480&sha=eb28c4c0578c9e986eaca6dab5b2e7293bd0ae9e&name_0=PR&name_1=Integration%20tests%20%28amd_asan%2C%20db%20disk%2C%20old%20analyzer%2C%206%2F6%29
#96480
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
🤖 Generated with Claude Code