Fix flaky test 02916_glogal_in_cancel under TSan#96579
Merged
alexey-milovidov merged 2 commits intomasterfrom Feb 10, 2026
Merged
Fix flaky test 02916_glogal_in_cancel under TSan#96579alexey-milovidov merged 2 commits intomasterfrom
02916_glogal_in_cancel under TSan#96579alexey-milovidov merged 2 commits intomasterfrom
Conversation
The test uses `remote('127.0.0.{3|2}', ...)` with `max_execution_time = 0.5`.
Under TSan, the 0.5s timeout fires during table structure resolution
(which requires network connections to remote shards), causing
`NO_REMOTE_SHARD_AVAILABLE` instead of a graceful timeout.
Change to `127.0.0.{1|2}` so that `127.0.0.1` is detected as a local
shard in `getStructureOfRemoteTable`, allowing instant structure
resolution without network calls. The test still exercises GLOBAL IN
cancellation with a distributed query.
https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=f9e36b04ffb08eee40c70de6b8be57d77bb88338&name_0=MasterCI&name_1=Stateless%20tests%20%28amd_tsan%2C%20parallel%2C%202%2F2%29
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…enario Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
nickitat
reviewed
Feb 10, 2026
Member
nickitat
left a comment
nickitat
left a comment
There was a problem hiding this comment.
127.0.0.{3|2} are local addresses too. Sounds like either something is wrong in the explanation or we don't correctly recognise all loopback addresses as such.
Member
Author
|
@nickitat, yes, we only recognize 127.0.0.1 as local. This is used in a few other tests. |
robot-ch-test-poll4
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test uses
remote('127.0.0.{3|2}', ...)withmax_execution_time = 0.5. Under TSan, the 0.5s timeout fires during table structure resolution (which requires network connections to remote shards), causingNO_REMOTE_SHARD_AVAILABLEinstead of a graceful timeout.Added a local shard in
getStructureOfRemoteTable, allowing instant structure resolution without network calls. The test still exercises GLOBAL IN cancellation with a distributed query.https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=f9e36b04ffb08eee40c70de6b8be57d77bb88338&name_0=MasterCI&name_1=Stateless%20tests%20%28amd_tsan%2C%20parallel%2C%202%2F2%29
Changelog category (leave one):