Revert "Revert "Remove unnecessary parentheses in CREATE TABLE ... AS SELECT ... COMMENT""#96598
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 12, 2026
Conversation
…S SELECT ... COMMENT`""
Contributor
clickhouse-gh
Bot
added
the
pr-not-for-changelog
evillique
approved these changes
Feb 12, 2026
alexey-milovidov
deleted the
revert-96595-revert-96293-remove-unnecessary-parentheses-create-as-select-comment
branch
alexey-milovidov
added a commit
that referenced
this pull request
Mar 16, 2026
Move `COMMENT` clause back after `AS SELECT` in the formatter output to restore backward compatibility with older ClickHouse versions. The parser still accepts `COMMENT` both before and after `AS SELECT`, so queries created by newer versions (26.2) with the new syntax will parse correctly. The formatter now outputs: `CREATE VIEW ... AS (SELECT ...) COMMENT 'text'` instead of: `CREATE VIEW ... COMMENT 'text' AS SELECT ...` This ensures views created or updated on the current version can be loaded by older releases (25.12 and earlier), fixing the forward incompatibility introduced by #96598. Closes #97843 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #96595