Skip to content

Use QueryPlanStepPtr consistently#96659

Merged
davenger merged 1 commit intomasterfrom
use_query_plan_step_ptr
Feb 11, 2026
Merged

Use QueryPlanStepPtr consistently#96659
davenger merged 1 commit intomasterfrom
use_query_plan_step_ptr

Conversation

@davenger
Copy link
Copy Markdown
Member

We use QueryPlanStepPtr in some places and std::unique_ptr<IQueryPlanStep> in others.
This is just a code cleanup to facilitate refactoring, no changes in the logic.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Feb 11, 2026

Workflow [PR], commit [925ff23]

Summary:

job_name test_name status info comment
Integration tests (amd_binary, 5/5) failure
test_ttl_replicated/test.py::test_ttl_compatibility[node_left1-node_right1-1] FAIL cidb, issue ISSUE CREATED

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 11, 2026
@nickitat nickitat self-assigned this Feb 11, 2026
@nickitat
Copy link
Copy Markdown
Member

You mean "consistently"?

@davenger davenger changed the title Use QueryPlanStepPtr consistency Use QueryPlanStepPtr consistently Feb 11, 2026
@davenger davenger added this pull request to the merge queue Feb 11, 2026
Merged via the queue into master with commit 1593e1f Feb 11, 2026
132 of 134 checks passed
@davenger davenger deleted the use_query_plan_step_ptr branch February 11, 2026 14:55
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants