Do not fail targeted integration checks on session timeout#96761
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 12, 2026
Merged
Do not fail targeted integration checks on session timeout#96761alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
The targeted integration check runs previously-failed tests with `--count 10` to detect flakiness. For slow test suites like `test_database_delta` (which uses Spark/Unity Catalog containers, ~30-60s per test), the 1200s session timeout is easily exceeded even when all completed tests pass. The code already avoids setting the `has_error` flag for targeted checks (lines 571-576), recognizing that session-timeout is an expected risk. However, the synthetic `Timeout` FAIL result added by `run_pytest_and_collect_results` was still propagated into the final results, causing the job to be reported as failed. Filter out the `Timeout` pseudo-result for targeted checks so that the job status reflects only actual test outcomes. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=96506&sha=ea37810a1e3427e90315554d5cab63fc080a50a3&name_0=PR&name_1=Integration%20tests%20%28amd_asan%2C%20targeted%29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--count 10to detect flakinesstest_database_delta(Spark/Unity Catalog, ~30-60s per test), the 1200s session timeout is easily exceeded even when all completed tests passhas_errorflag for targeted checks (recognizing session-timeout as an expected risk), but the syntheticTimeoutFAIL result was still propagated into the final results, causing the job to be reported as failedTimeoutpseudo-result for targeted checks so the job status reflects only actual test outcomesCI report: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=96506&sha=ea37810a1e3427e90315554d5cab63fc080a50a3&name_0=PR&name_1=Integration%20tests%20%28amd_asan%2C%20targeted%29
#96506
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
🤖 Generated with Claude Code