Fix S3Queue partition test race condition#97230
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 18, 2026
Merged
Conversation
…iles` The test had a race condition: it checked ZooKeeper partition metadata immediately after verifying all rows were in the destination table. However, S3Queue commits ZooKeeper metadata after data insertion, so the last batch's ZK commit may not have completed yet. Added a retry loop (up to 30 seconds) for the ZooKeeper partition check. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=95819&sha=87f9612ea036a8a2fcb7b2e770adacf9cbd934b2&name_0=PR&name_1=Integration%20tests%20%28amd_binary%2C%204%2F5%29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
alexey-milovidov
changed the title
robot-ch-test-poll4
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_ordered_mode_with_regex_partitioning_large_num_files: the ZooKeeper partition metadata check now retries instead of asserting immediately, since S3Queue commits ZK metadata after data insertionTest plan
CI report: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=95819&sha=87f9612ea036a8a2fcb7b2e770adacf9cbd934b2&name_0=PR&name_1=Integration%20tests%20%28amd_binary%2C%204%2F5%29
#95819
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
🤖 Generated with Claude Code