Fix flaky test_inserts_and_moves[rmt_volume] in test_ttl_move#97243
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 18, 2026
Merged
Fix flaky test_inserts_and_moves[rmt_volume] in test_ttl_move#97243alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
The `wait_if_moving_then_assert_disks` helper had a bug: when active moves were detected (`moves > 0`), the `continue` statement skipped `time.sleep`, rapidly exhausting all retries without actually waiting. This caused the function to run out of retries before moves completed, especially for ReplicatedMergeTree where background moves take longer. Fixed by always sleeping between retries and increasing the default timeout from 10 to 30 seconds. https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=b25e7f1fad41dd3316e717098fb5f9f1a9a52397&name_0=MasterCI&name_1=Integration%20tests%20%28amd_binary%2C%202%2F5%29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_if_moving_then_assert_diskswherecontinueskippedtime.sleepwhen active moves were detected, rapidly exhausting retries without actually waitingCI report: https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=b25e7f1fad41dd3316e717098fb5f9f1a9a52397&name_0=MasterCI&name_1=Integration%20tests%20%28amd_binary%2C%202%2F5%29
Test plan
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
🤖 Generated with Claude Code