Conversation
Contributor
|
Workflow [PR], commit [a51b298] Summary: ❌
|
azat
approved these changes
Feb 20, 2026
Member
azat
left a comment
There was a problem hiding this comment.
Should setUserToken be even called for empty chunks?
Member
Author
I could change it, but code there looks fine. Entry is rolled back, buffer is rolled back, 0 rows are returned. |
Algunenano
pushed a commit
to Algunenano/ClickHouse
that referenced
this pull request
Feb 24, 2026
…-token skip empty deduplication tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to this injected exception
A token with 0 rows is added
After first token has been filtered we have empty block but 1 token is left.
And this chassert is triggered
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
skip empty deduplication tokens
Documentation entry for user-facing changes