fix a possible use after free in StorageKafka2::activate()#97520
Merged
alexey-milovidov merged 2 commits intomasterfrom Feb 22, 2026
Merged
fix a possible use after free in StorageKafka2::activate()#97520alexey-milovidov merged 2 commits intomasterfrom
alexey-milovidov merged 2 commits intomasterfrom
Conversation
Contributor
|
Workflow [PR], commit [a2b94f6] Summary: ❌
|
alexey-milovidov
approved these changes
Feb 20, 2026
Contributor
Author
But I don't think it's easy to add a test for this. |
Member
|
I've relaxed this rule: #97565 |
robot-ch-test-poll4
added a commit
that referenced
this pull request
Feb 22, 2026
Cherry pick #97520 to 25.3: fix a possible use after free in StorageKafka2::activate()
This was referenced Feb 22, 2026
robot-ch-test-poll4
added a commit
that referenced
this pull request
Feb 22, 2026
Cherry pick #97520 to 25.8: fix a possible use after free in StorageKafka2::activate()
This was referenced Feb 22, 2026
robot-ch-test-poll4
added a commit
that referenced
this pull request
Feb 22, 2026
Cherry pick #97520 to 25.11: fix a possible use after free in StorageKafka2::activate()
This was referenced Feb 22, 2026
robot-ch-test-poll4
added a commit
that referenced
this pull request
Feb 22, 2026
Cherry pick #97520 to 25.12: fix a possible use after free in StorageKafka2::activate()
This was referenced Feb 22, 2026
robot-ch-test-poll4
added a commit
that referenced
this pull request
Feb 22, 2026
Cherry pick #97520 to 26.1: fix a possible use after free in StorageKafka2::activate()
clickhouse-gh bot
added a commit
that referenced
this pull request
Feb 22, 2026
Backport #97520 to 25.12: fix a possible use after free in StorageKafka2::activate()
clickhouse-gh bot
added a commit
that referenced
this pull request
Feb 22, 2026
Backport #97520 to 25.11: fix a possible use after free in StorageKafka2::activate()
clickhouse-gh bot
added a commit
that referenced
this pull request
Feb 22, 2026
Backport #97520 to 25.8: fix a possible use after free in StorageKafka2::activate()
Algunenano
pushed a commit
to Algunenano/ClickHouse
that referenced
this pull request
Feb 24, 2026
fix a possible use after free in StorageKafka2::activate()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ZooKeeper session expires,
partialShutdownwas not resettingreplica_is_active_node, so the oldEphemeralNodeHolderwould get destroyed after setZooKeeper had already freed the old session, causing a segfault.Closes: #97495
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix a possible use after free in StorageKafka2.
Documentation entry for user-facing changes