Add timeout for minio restart in CI to avoid hanging forever#97655
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 23, 2026
Merged
Add timeout for minio restart in CI to avoid hanging forever#97655alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
The `/mc admin service restart clickminio --wait` command can hang indefinitely during CI setup, causing the entire test job to fail without running any tests. Add a 60-second timeout; if exceeded, kill the minio process with `-9` and start it fresh. CI report: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=97647&sha=e8326de84a9cb6eb786a3ddf7d28bd1b8d48f171&name_0=PR&name_1=Stateless%20tests%20%28amd_tsan%2C%20sequential%2C%202%2F2%29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/mc admin service restart clickminio --waitcommand increate_minio_log_tablesusesShell.get_outputwhich callssubprocess.runwith no timeout, so it can hang indefinitely-9and start it fresh (the webhook config persists in minio's data directory)CI report: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=97647&sha=e8326de84a9cb6eb786a3ddf7d28bd1b8d48f171&name_0=PR&name_1=Stateless%20tests%20%28amd_tsan%2C%20sequential%2C%202%2F2%29
#97647
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Add timeout for minio restart in CI to avoid test jobs hanging forever.
Documentation entry for user-facing changes
🤖 Generated with Claude Code