Fix exception in IN/NOT IN with LowCardinality column arguments#98443
Merged
alexey-milovidov merged 4 commits intomasterfrom Mar 3, 2026
Merged
Fix exception in IN/NOT IN with LowCardinality column arguments#98443alexey-milovidov merged 4 commits intomasterfrom
alexey-milovidov merged 4 commits intomasterfrom
Conversation
When resolving `column IN (other_column)` expressions, `convertTupleToArray` wraps the common type in Nullable. For `LowCardinality(T)` types, `makeNullable` produced the invalid `Nullable(LowCardinality(T))` instead of the correct `LowCardinality(Nullable(T))`, causing an "cannot be inside Nullable type" exception. Use `makeNullableOrLowCardinalityNullable` and `isNullableOrLowCardinalityNullable` which properly handle the LowCardinality wrapper. Closes #92828 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
novikd
approved these changes
Mar 2, 2026
Member
novikd
left a comment
novikd
left a comment
There was a problem hiding this comment.
LGTM, but the test fails with disabled analyzer
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ILLEGAL_TYPE_OF_ARGUMENTexception when usingcolumn IN (other_column)orcolumn NOT IN (other_column)where the left-hand column isLowCardinality(T)convertTupleToArraywhich transformsa IN (b)intohas(array(CAST(b, NullableType)), a)— it usedmakeNullableproducing the invalidNullable(LowCardinality(T))instead ofLowCardinality(Nullable(T))makeNullableOrLowCardinalityNullable/isNullableOrLowCardinalityNullablewhich properly handle theLowCardinalitywrapperCloses #92828
Test plan
04007_low_cardinality_in_columncoveringLowCardinality(String)andLowCardinality(Bool)with bothINandNOT INcolumn argumentsLowCardinalityequivalentsChangelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix exception "cannot be inside Nullable type" when using
IN/NOT INwithLowCardinalitycolumn arguments (e.g.a NOT IN (b)whereaisLowCardinality(String)).🤖 Generated with Claude Code