Backport #98514 to 26.1: Fix unexpected result with read_in_order_use_virtual_row #98928
Merged
clickhouse-gh[bot] merged 1 commit into26.1from Mar 6, 2026
Merged
Backport #98514 to 26.1: Fix unexpected result with read_in_order_use_virtual_row #98928clickhouse-gh[bot] merged 1 commit into26.1from
clickhouse-gh[bot] merged 1 commit into26.1from
Conversation
d85395c to
ad23ffc
Compare
Contributor
|
Workflow [BackportPR], commit [ad23ffc] Summary: ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #98514
Cherry-pick pull-request #98927
This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.
The PR source
The PR is created in the CI job
Note
Medium Risk
Touches read-in-order/virtual-row query plan optimization, which can affect result ordering/correctness in JOIN+ORDER BY queries. Change is small but in a correctness-sensitive optimizer path.
Overview
Fixes virtual-row conversion generation for
read_in_order_use_virtual_rowby preserving the originalActionsDAGfunction noderesult_namewhen rebuilding monotonic expression chains (instead of auto-generating a new name).Adds a stateless regression test (
04001_virtual_row_conversions_join_column_names) coveringORDER BYon a casted low-cardinality key andJOINconditions usingNullablesubcolumns, including afull_sorting_mergejoin variant, to ensure stable/expected results.Written by Cursor Bugbot for commit ad23ffc. This will update automatically on new commits. Configure here.