Insert profile event fix for async inserts with inline data

[npakeer]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Increment InsertQuery ProfileEvent for async inserts. Fixes the issue - #98626

Documentation entry for user-facing changes

Async inserts with inline data are not being counted in InsertQuery profile event. This fix also increments InsertQuery profile event for async inserts with inline data .

• Documentation is written (mandatory for new features)

---

Note

Low Risk
Small, metrics-only change in the async INSERT path plus a new integration test; low risk aside from potential monitoring/alerting deltas due to corrected counters.

Overview
Fixes a ProfileEvents counting gap for async INSERTs. When an async INSERT with inlined data is successfully enqueued (pushQueryWithInlinedData returns OK), executeQuery.cpp now also increments ProfileEvents::InsertQuery (in addition to existing async-specific counters).

Adds coverage. New integration test test_insert_query_profile_events asserts InsertQuery increases for both sync and async inserts while AsyncInsertQuery increases only for async inserts, with a minimal config (page_cache_size=0) for deterministic runs.

^{Written by Cursor Bugbot for commit 629aa28. This will update automatically on new commits. Configure here.}

[clickhouse-gh]

Workflow [PR], commit [629aa28]

Summary: ✅

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[clickhouse-gh]

LLVM Coverage Report

Metric	Baseline	Current	Δ
Lines	83.20%	83.80%	+0.60%
Functions	23.60%	23.90%	+0.30%
Branches	75.30%	76.30%	+1.00%

PR changed lines: PR changed-lines coverage: 100.00% (7/7)
Diff coverage report
Uncovered code

[yakov-olkhovskiy]

why don't we do it at the same place as for ProfileEvents::AsyncInsertQuery?

[npakeer]

@yakov-olkhovskiy The problem is happening only for async inserts with inline data. If we increment InsertQuery at the same place as AsyncInsertQuery, then InsertQuery will be double incremented for non inline data. For non inline data, it seems to go through InterpreterFactory.get() where the profile event event is incremented.

If my understanding is correct.

Inline async inserts go through here

Non In line async inserts goes through this. See last line of selection here:

InterpreterFactory.get() is incrementing profile event for noninline data. I did test for non inline async data, and InsertQuery is incrementing correctly. Let me know if you still have any questions.

[npakeer]

For more clarification, the data for non-inline data is being pushed directly to AsynchronousInsertQueue by TCPHandler here and here once response is given from executeQuery.cpp, and double counting will occur inside InterpreterFactory.get() and AsynchronousInsertQueue